Video Full screen doesn't work on mac

[namse]

Describe the bug

To Reproduce

click the video, click the full screen button

Expected behavior

Video shows on full screen

Screenshots

Desktop (please complete the following information):

• Operating System:
  macOS 15.3.1
• Zulip Desktop Version:
  5.11.1

[alya]

Closing, as the screenshot is not showing the Zulip Desktop app.

[namse]

@alya screenshot updated. please check it.

[alya]

Do you see the same issue in the desktop app and the browser?

[namse]

No issue on browser because browser support video full screen. Happened on Desktop mac version, i don't have linux or windows now.

[twilight39]

@zulipbot claim

[zulipbot]

Hello @twilight39!

Thanks for your interest in Zulip! You have attempted to claim an issue without the label "help wanted". You can only claim and submit pull requests for issues with the help wanted label.

If this is your first time here, we recommend reading our guide for new contributors before getting started.

[twilight39]

...I probably should've checked if the issue is open to contributions first.

Anyways, I poked around and the issue seems to be that the desktop application uses a webview to display the server url, but the webview doesn't have permission to go full-screen.

Changing Line 965 to permission === "fullscreen" || webview.properties.hasPermission?.(origin, permission) for instance, fixes it on my local dev.

zulip-desktop/app/renderer/js/main.ts

Lines 940 to 979 in 15902e5

	ipcRenderer.on(
	"permission-request",
	async (
	event,
	{
	webContentsId,
	origin,
	permission,
	}: {
	webContentsId: number | null;
	origin: string;
	permission: string;
	},
	permissionCallbackId: number,
	) => {
	const grant =
	webContentsId === null
	? origin === "null" && permission === "notifications"
	: (
	await Promise.all(
	this.tabs.map(async (tab) => {
	if (!(tab instanceof ServerTab)) return false;
	const webview = await tab.webview;
	return (
	webview.webContentsId === webContentsId &&
	webview.properties.hasPermission?.(origin, permission)
	);
	}),
	)
	).some(Boolean);
	console.log(
	grant ? "Granted" : "Denied",
	"permissions request for",
	permission,
	"from",
	origin,
	);
	ipcRenderer.send("permission-callback", permissionCallbackId, grant);
	},
	);

I would probably set it when initialising the webviews here

zulip-desktop/app/renderer/js/main.ts

Lines 386 to 403 in 15902e5

	webview: WebView.create({
	$root: this.$webviewsContainer,
	rootWebContents,
	index,
	tabIndex,
	url: server.url,
	role: "server",
	hasPermission: (origin: string, permission: string) =>
	origin === server.url &&
	permission === "notifications" &&
	ConfigUtil.getConfigItem("showNotification", true),
	isActive: () => index === this.activeTabIndex,
	switchLoading: async (loading: boolean, url: string) => {
	if (loading) {
	this.loading.add(url);
	} else {
	this.loading.delete(url);
	}

I'll fix it in a PR if I can claim it

[namse]

@alya would you help twilight39 to summit new PR?

[namse]

@zulipbot add "help wanted"

[namse]

@twilight39 I guess you can make PR from now on. would you try to do that?

[Ujjwal5705]

@zulipbot claim

[zulipbot]

Welcome to Zulip, @Ujjwal5705! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip-desktop/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!

Here's some tips to get you off to a good start:

• Join me on the Zulip developers' server, to get help, chat about this issue, and meet the other developers.
• Unwatch this repository, so that you don't get 100 emails a day.

As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.

See you on the other side (that is, the pull request side)!