content: Use directional layout for block quotations#2005
Merged
gnprice merged 1 commit intozulip:mainfrom Dec 12, 2025
Merged
Conversation
yash-agarwa-l
force-pushed
the
fix-rtl-quotation
branch
from
4fcdb6e to
771474c
Compare
chrisbobbe
reviewed
Dec 2, 2025
Collaborator
chrisbobbe
left a comment
chrisbobbe
left a comment
There was a problem hiding this comment.
Looks great, thanks! Marking for Greg's review.
chrisbobbe
added
integration review
Member
|
Thanks for the clean commit and clear screenshots! Looks good; merging. Staring at the screenshots — and in particular flipping back and forth between the two "after" screenshots — I notice one other discrepancy which isn't new with this PR, but also isn't one of the ones I found at #1991 (comment) . Should be a quick one to fix. I'll comment with details in that thread so that things are in one place. |
Previously, the `Quotation` widget hardcoded the border and padding to the left side. This resulted in an incorrect layout in RTL locales, where the quote bar remained on the left while the text aligned to the right. We now use `EdgeInsetsDirectional` and `BorderDirectional` so that the layout flips correctly based on the text direction.
gnprice
force-pushed
the
fix-rtl-quotation
branch
from
771474c to
8baf786
Compare
Member
|
(Back from vacation this week, which is why I've just reviewed and merged a burst of your PRs in a row.) |
Contributor
Author
|
Thanks for the review and the merge! Yeah, I guessed as much—I probably read that somewhere in the Zulip chats. |
yash-agarwa-l
added a commit
to yash-agarwa-l/zulip-flutter
that referenced
this pull request
Dec 12, 2025
Previously, the TODAY (and other date) labels in recipient headers used, which applied asymmetric left/right padding only in LTR layouts. This caused the label to be misaligned in RTL layouts, as seen in screenshots from zulip#2005. Change to use , so the start/end padding swaps correctly in RTL, matching the alignment of message timestamps and improving visual consistency.
yash-agarwa-l
added a commit
to yash-agarwa-l/zulip-flutter
that referenced
this pull request
Dec 12, 2025
Previously, the TODAY (and other date) labels in recipient headers used, which applied asymmetric left/right padding only in LTR layouts. This caused the label to be misaligned in RTL layouts, as seen in screenshots from zulip#2005. Change to use , so the start/end padding swaps correctly in RTL, matching the alignment of message timestamps and improving visual consistency.
yash-agarwa-l
added a commit
to yash-agarwa-l/zulip-flutter
that referenced
this pull request
Dec 12, 2025
Previously, the TODAY (and other date) labels in recipient headers used, which applied asymmetric left/right padding only in LTR layouts. This caused the label to be misaligned in RTL layouts, as seen in screenshots from zulip#2005. Change to use , so the start/end padding swaps correctly in RTL, matching the alignment of message timestamps and improving visual consistency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the layout of block quotes (
> quote) in RTL languages.Previously, the vertical bar was stuck on the Left side even in RTL mode. Now, it correctly flips to the Right side (the "start" of the text).
This addresses one of the RTL issues identified by @gnprice in this comment.
Before
LTR
RTL
After
LTR
RTL