content: Use directional layout for message media#2007
Conversation
c574e46 to
eef24bf
Compare
|
Thanks! Quick format comment: please avoid @-mentions in commit messages. See this section of our Git style guide: The description there is actually a bit forward-looking — GitHub's current behavior, and until next month, is that @-mentions do actually cause notifications. That ends up being spammy, because each time the commit gets rebased (and the rebased version pushed to GitHub), that's a new commit and causes a new notification in the person's inbox. |
eef24bf to
3b1880e
Compare
|
Thanks for the clarification! |
|
Thanks, this looks great! Marked for Greg's review. |
|
Thanks! Looks good; merging. |
Previously, these previews (for images and video) were hardcoded to align to the left, with padding on the right. This resulted in an incorrect layout in RTL locales. We now use directional positioning so that the alignment and padding flip correctly based on the text direction.
3b1880e to
b00f97c
Compare
This fixes the layout of images and video thumbnails in the message list for RTL languages.
Previously, these media containers were hardcoded to align to the Left side with padding on the Right, even in RTL mode. Now, they correctly flip to the Right side (the "start" of the message) with padding on the correct side.
This addresses the second RTL issue identified by @gnprice in this comment.
Before
LTR
RTL
After
LTR
RTL
Since the Difference is very minute, this might help.