msglist: Add in-conversation-narrow asserts in _messageVisible#2051
Merged
gnprice merged 2 commits intozulip:mainfrom Jan 2, 2026
Merged
msglist: Add in-conversation-narrow asserts in _messageVisible#2051gnprice merged 2 commits intozulip:mainfrom
asserts in _messageVisible#2051gnprice merged 2 commits intozulip:mainfrom
Conversation
rajveermalviya
approved these changes
Jan 2, 2026
Member
rajveermalviya
left a comment
rajveermalviya
left a comment
There was a problem hiding this comment.
Thanks @chrisbobbe! LGTM, moving over to Greg's review.
rajveermalviya
added
integration review
Member
|
Thanks! This looks good. Would you rebase atop current main? It looks like we just introduced one more example of this in #1951 🙂 (/cc @sm-sayedi). |
… topic It's a bug if we load a topic-narrow message list and it has some message(s) that are outside the specified channel/topic. Some tests were running afoul of this; we fix those here.
It's a bug if we load a DM-narrow message list and it has some message(s) that are outside the specified DM conversation. Some tests were running afoul of this; we fix those here.
chrisbobbe
force-pushed
the
pr-message-visible-asserts
branch
from
d61af3b to
75e043f
Compare
Collaborator
Author
|
Thanks! And yep; done. |
Member
|
Thanks! Looks good; merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.