Fix #2 - Using buttons with multiple encoders#15
Merged
Conversation
Move static variable into header file to fix handling of multiple rotary encoders with buttons.
|
Just a FYI, this fix and other bug fixes and enhancements are in the soligen2010 fork. |
Owner
|
Hi, thanks for your PR. Can you help me understand how extending the scope from function to class would fix the issue you seem to be having? As each encoder should have it's own instance of the class, and thus the function, this should not change behaviour. Thanks. |
|
I am afraid you are mistaken. A static variable exists only once, and all objects will share it. It needs to be in the header file as either public/private/protected in the class definition for each to have it's own version. |
Owner
|
Of course, you are right, should not write comments when I don't have time to think first. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move static variable into header file to fix handling of multiple rotary
encoders with buttons.