Add support for minizip-ng 4 API#1806
Merged
Merged
Conversation
Closed
|
Seeing how this breaks at the same position as #1808 it would appear the code is broken elsewhere. Since PyColorSpaceSet.cpp was changed recently this seems like the likely culprit. |
Contributor
|
#1762 suffers from the same CIS issue now. |
|
@brad0 you missed one call, could you add that? diff -Naurw a/src/apps/ocioarchive/main.cpp b/src/apps/ocioarchive/main.cpp
--- a/src/apps/ocioarchive/main.cpp
+++ b/src/apps/ocioarchive/main.cpp
@@ -235,7 +235,11 @@
}
std::string path = args[0];
+#if MZ_VERSION_BUILD >= 040000
+ reader = mz_zip_reader_create();
+#else
mz_zip_reader_create(&reader);
+#endif
struct tm tmu_date;
err = mz_zip_reader_open_file(reader, path.c_str()); |
Signed-off-by: Brad Smith <brad@comstyle.com>
Contributor
Author
Thanks. I was wondering why I did not notice this at first but we do not build the apps with the OpenBSD port. |
Contributor
Author
|
ping. |
Contributor
Author
Thank you. |
Contributor
Author
|
ping. |
cedrik-fuoco-adsk
approved these changes
Jul 28, 2023
Contributor
Author
|
Thank you. |
7 tasks
doug-walker
added a commit
to autodesk-forks/OpenColorIO
that referenced
this pull request
Dec 6, 2023
Signed-off-by: Brad Smith <brad@comstyle.com> Co-authored-by: Rémi Achard <remiachard@gmail.com> Co-authored-by: Doug Walker <doug.walker@autodesk.com> Signed-off-by: Doug Walker <Doug.Walker@autodesk.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.