Added GetProcessorFromConfigs variants for displays and views.#1808
Conversation
|
(Would be good for the library to have a |
|
Thanks @num3ric, sounds like a good idea to add some unit tests inspired from the existing tests on other |
|
There is a conflict on the branch following some recent merges in main. |
num3ric
force-pushed
the
configprocessors
branch
from
c79f7b1 to
85df1f1
Compare
Signed-off-by: Eric Renaud-Houde <eric.renaud.houde@gmail.com>
num3ric
force-pushed
the
configprocessors
branch
from
85df1f1 to
19a796c
Compare
…argument last. Signed-off-by: Eric Renaud-Houde <eric.renaud.houde@gmail.com>
num3ric
force-pushed
the
configprocessors
branch
from
7a5c4e3 to
b9ec011
Compare
|
Added unit tests. Also moved the direction argument last since in this case it reverses the entire chain of transforms. |
doug-walker
left a comment
doug-walker
left a comment
There was a problem hiding this comment.
Thanks Eric! No need to make any changes (the two notes are just to myself, for later).
| if (!p2) | ||
| { | ||
| throw Exception("Can't create the processor for the destination config " | ||
| "and the destination color space."); |
There was a problem hiding this comment.
"color space" --> "display/view"
| const char * dstDisplay, | ||
| const char * dstView, | ||
| TransformDirection direction) | ||
| { |
There was a problem hiding this comment.
The code you used as the model for this method was recently removed and replaced with GetInterchangeRolesForColorSpaceConversion. I think some refactoring will be needed later, but it's ok to reintroduce this here for now.
…mySoftwareFoundation#1808) * Added GetProcessorFromConfigs variants for displays and views. Signed-off-by: Eric Renaud-Houde <eric.renaud.houde@gmail.com> * Added display-view processor from two configs tests, moved direction argument last. Signed-off-by: Eric Renaud-Houde <eric.renaud.houde@gmail.com> --------- Signed-off-by: Eric Renaud-Houde <eric.renaud.houde@gmail.com> Co-authored-by: Michael Dolan <michdolan@gmail.com> Signed-off-by: Brooke <beg9562@rit.edu>
…mySoftwareFoundation#1808) * Added GetProcessorFromConfigs variants for displays and views. Signed-off-by: Eric Renaud-Houde <eric.renaud.houde@gmail.com> * Added display-view processor from two configs tests, moved direction argument last. Signed-off-by: Eric Renaud-Houde <eric.renaud.houde@gmail.com> --------- Signed-off-by: Eric Renaud-Houde <eric.renaud.houde@gmail.com> Co-authored-by: Michael Dolan <michdolan@gmail.com> Signed-off-by: Doug Walker <Doug.Walker@autodesk.com>
4 participants
Yield a single processor from a color space in config (a) to a display-view in config (b), through the interchange space.
Let me know if we think we need test coverage for these.