Module 6: #[track_caller] error macros for zero-cost location capture#2
Merged
Merged
Conversation
Add plan_err!, config_err!, exec_err! macros that use #[track_caller] + std::panic::Location for zero-cost call-site capture (Gate 4/7). Bridge design: macros call plan_err_at()/config_err_at()/exec_err_at() which convert std::panic::Location to snafu::Location. This gives ergonomic macros while maintaining compatibility with 148 existing snafu error creation sites across 18 files. - plan_err_at(), config_err_at(), exec_err_at(): #[track_caller] helpers - plan_err!, config_err!, exec_err!: format!() wrapper macros - 4 tests proving location capture works https://claude.ai/code/session_016SeGMg1pgf1MqK8YWkedvV
AdaWorldAPI
pushed a commit
that referenced
this pull request
Mar 6, 2026
#1: RUSTYNUM IS MANDATORY — no hand-rolled numeric ops in lance_parser/ #2: NO SERDE_JSON ON THE HOT PATH — NodeParameterValue is not serde_json::Value, they are not convertible, the fix is never param_to_json() https://claude.ai/code/session_016SeGMg1pgf1MqK8YWkedvV
AdaWorldAPI
pushed a commit
that referenced
this pull request
Apr 18, 2026
The 5th and foundational chess research direction: load the full historical record (5B Lichess games + 10M master games + Syzygy endgame tablebases) into our native encoding and make it queryable via Cypher with semantic similarity. Compression: 200B position-occurrences → ~325 GB on SSD after CAM-PQ palette compression + FEN deduplication. ChessBase needs 600 GB for 10M games; we carry 500× more in half the space. Three query classes impossible in any existing chess tool: - Semantic position similarity (palette distance is O(1)) - Multi-hop NARS confidence paths (truth propagation) - Human-intuition move mining (engine-dispreferred but winning) ~1400 lines of new code, ~10 days focused work. Most infrastructure already shipped (AriGraph, CausalEdge64, Cypher parser, BindSpace, PaletteSemiring). Recommended as Tier 0 substrate — every subsequent experiment (#2 style benchmark, #3 learning, #1 longitudinal) is measurably more credible with 5 billion games behind it. https://claude.ai/code/session_01SbYsmmbPf9YQuYbHZN52Zh
AdaWorldAPI
pushed a commit
that referenced
this pull request
Apr 20, 2026
Addresses all 5 follow-ups from .claude/knowledge/cam-pq-unified-pipeline.md: #1 Wire register_cam_udfs in execute_with_context - CypherQuery::with_cam_codebook(codebook) builder method - execute_with_context auto-registers cam_distance + cam_heel_distance UDFs when codebook is set - One-line unblock for SQL/Cypher CAM-PQ queries #2 Migrate cam_pq_calibrate output to Lance schema - codebook_to_lance() in lance-graph/src/cam_pq/storage.rs - Converts (codebook, fingerprints) -> (vectors_batch, codebook_batch) - Arrow RecordBatches ready for Lance write; bridges bgz-tensor's raw calibration output to the canonical storage format #3 impl OrchestrationBridge for codec research (nd.* step-types) - codec_bridge.rs: CodecResearchBridge owns StepDomain::Ndarray - nd.tensors / nd.calibrate / nd.probe dispatch via codec_research - Parses args from step.reasoning as WireRequest JSON - Complements planner's lg.* bridge #4 Generic OrchestrationBridge routing endpoint - POST /v1/shader/route — accepts WireUnifiedStep JSON - Composed bridge: tries CodecResearchBridge first (nd.*), falls through to PlannerAwareness (lg.*) if DomainUnavailable - planner_bridge.rs preserved as typed convenience (rich responses) - Both patterns coexist: generic route + typed Wire DTOs #5 WireUnifiedStep + WireStepResult DTOs - Generic step envelope: {step_id, step_type, reasoning} - Generic result: {step_id, step_type, status, reasoning, confidence} - POST /v1/shader/route uses these; per-op endpoints stay for convenience with their richer typed responses All 5 follow-ups delivered in one commit. 46/46 shader-driver tests pass. lance-graph compiles clean. https://claude.ai/code/session_01SbYsmmbPf9YQuYbHZN52Zh
This was referenced Apr 20, 2026
AdaWorldAPI
pushed a commit
that referenced
this pull request
Apr 25, 2026
This was referenced Apr 29, 2026
AdaWorldAPI
pushed a commit
that referenced
this pull request
Apr 29, 2026
…UDF hard-fail Closes two critical loose ends in the PR-F1 ColumnMaskRewriter UDF wrap: Loose End #1 (security hole): masked columns leaked through WHERE / JOIN / GROUP BY / aggregate nodes because the rewriter only walked top-level Projection. `SELECT MAX(ssn) FROM users WHERE ssn = '...'` would expose unmasked SSN values via the predicate and the aggregate. Fix: replace top-level Projection match with full-tree expression rewrite. Use `LogicalPlan::map_expressions` to dispatch to every node variant (Filter, Projection, Aggregate, Join, Sort) and `Expr::transform_down` to walk every nested expression. `TreeNodeRecursion::Jump` after a Column replacement prevents infinite descent into the freshly-built mask expression (relevant for Hash mode, which wraps the column in a ScalarFunction whose argument IS the original column). Loose End #2 (silent placeholder): RedactionMode::Hash returned `lit("***REDACTED***")` — if the real hash UDF was forgotten in a follow-up, every Hash-masked column would silently render as a string placeholder with no surface signal that policy is mis-wired. Fix: replace placeholder with reference to `policy_hash_v1`, an unregistered ScalarUDFImpl whose `invoke_with_args` returns `NotImplemented("policy_hash_v1 UDF not yet registered — see PR-F1b")`. Plans build (so call sites compose), execution fails loud — loud > silent. PR-F1b will replace the body with FNV-64 / SHA-256-truncated and register the UDF in the SessionContext. Failing-test-first: - `test_where_clause_does_not_leak_unmasked_column` builds `Projection(id) → Filter(ssn = '123-45-6789') → TableScan(users)`, runs the rewriter, asserts the Filter predicate references the mask literal and not bare `users.ssn`. Failed pre-fix on commit 88c0dc8 — Filter still showed `users.ssn = Utf8("123-45-6789")`. - `test_max_ssn_aggregate_is_masked` builds `Aggregate(MAX(ssn))`, asserts MAX argument is rewritten. Failed pre-fix — MAX(users.ssn) unchanged. - `test_hash_mode_binds_not_yet_wired_udf_not_silent_placeholder` asserts `policy_hash_v1` appears and `***REDACTED***` does not. Failed pre-fix — plan emitted Utf8("***REDACTED***"). All 3 fail on the existing skeleton, all 3 pass post-fix. Total lance-graph-callcenter --features auth-rls-lite test count: 70 passed (15 policy + 55 other), 0 failed. https://claude.ai/code/session_01NYGrxVopyszZYgLBxe4hgj
AdaWorldAPI
added a commit
that referenced
this pull request
Apr 30, 2026
…ring F1 (MySQL <-> SPO oracle parity) shipped via MedCareV2 PRs #1, #2, #3, medcare-rs PR #71, and lance-graph PR #309. The vision doc still claimed F1 was "the next concrete deliverable". Rewrite section 7 to: state F1 has shipped, describe the LanceProbe -> ParityWitness -> DriftSink flow, name the contract DTO (lance-graph-callcenter::transcode::parallelbetrieb::DriftEvent), list F1's known gaps (no latency claims; in-memory ring buffer), and state F2 RBAC+audit wiring (medcare-rs adopting RlsRewriter) as the next posture. No other sections touched.
3 tasks
AdaWorldAPI
added a commit
that referenced
this pull request
May 6, 2026
…ITICAL fixes required) Meta-1 review surfaces 10 findings; 2 CRITICAL fixes block Round 2 opening: CRITICAL #1: Doctor.Anamnese Full predicate-write violates BMV-Ä §57 append-only → fix: empty writable_predicates, keep only "append" action CRITICAL #2: Receptionist clinical-blind fails safety (no Identity-read for allergy/triage lookup before scheduling) → fix: merge Patient permission to Detail-depth + 3 demographic writes, add Identity-read on Diagnosis + LabResult HIGH #3-#4 (defer to Round 3 gate.rs): Diagnosis finalize/retract Escalate + Patient anonymize/merge/delete Escalate (GDPR Art.17 + §35 BDSG) MEDIUM #5-#8 (backlog): Missing entities (Termin, Recall, ePA) + audit trail hook LOW #9-#10 (backlog): PKV/GKV modulation + dynamic reason strings Round 2 implications surfaced for W5/W8. Round 3 implications surfaced for W9/W12 (Escalate wrapping + §73 SGB V test). Concrete diff for W3-revision-2 included at end of file. Next commit: W3-revision-2 applies the two CRITICAL fixes.
AdaWorldAPI
added a commit
that referenced
this pull request
May 6, 2026
…1 CRITICAL fix path) Meta-2 review surfaces 5 findings; 1 CRITICAL flagged for verification: CRITICAL #1: W7 hard-depends on StepDomain::MedCare which may not exist upstream → Recommended fix path: fetch lance-graph-contract/src/orchestration.rs to verify DomainProfile shape, then either confirm variant exists OR commit W7-revision-2 with inline-constructed DomainProfile fallback MEDIUM #2: MedCareStack empty struct doc-comment overclaims as "facade" → Doc-only fix; defer to next field-growth commit MEDIUM #3: Missing with_default_policies() builder → Backlog; lands when rls_registry field lands LOW #4-#5: Cross-crate test + dev-deps deferred Round 3 implications surfaced: - W9 imports list (medcare_rbac::{policy, role, access}) - W10 lib.rs gate re-export shape - W12 §73 SGB V tests must include BtM Escalate + Ueberweisung row visibility (Meta-1 carry-forward) Sprint orchestrator: verify upstream StepDomain::MedCare before committing W7-revision-2, OR apply fail-safe inline construction.
AdaWorldAPI
added a commit
that referenced
this pull request
May 6, 2026
…e (sprint closure) Meta-3 final review surfaces 5 findings; ZERO CRITICAL: HIGH #1: Action operations (Operation::Act) unreachable via gate → Doc note recommended; orchestration layer is the right home for action gating HIGH #2: BtM Escalate "v1 limitation" tests use loose is_allowed() assertions → Recommend tightening to explicit assert_eq!(AccessDecision::Allow) for clearer future test-failure messages MEDIUM #3: Three name paths for Policy (rbac, gate, lib) → Backlog; doc-only canonicalization MEDIUM #4: 20-200 ns gate decision claim unbenchmarked → Backlog; criterion-based gate-bench follow-up LOW #5: TD-MEMBRANE-FIRST-VS-ANY untested → Backlog; vacuous in v1 without divergence case Sprint-wide closure: - Round 1 (medcare-rbac): 26 tests, solid, 2 CRITICAL fixes applied - Round 2 (medcare-realtime skeleton): 5 tests, 1 CRITICAL casing+HIPAA fix - Round 3 (gate impl): 33 tests, 2 HIGH documentation gaps - Total: 64 tests across 3 crates VERDICT: Ship. POLICY-1 medcare-side seam CLOSED for v1. Topology I-1/I-2/I-3/I-4 upheld. PR #29 three TD caveats honestly carried forward.
AdaWorldAPI
added a commit
that referenced
this pull request
May 6, 2026
…closure 12 workers + 3 metas across 3 rounds, 4 CRITICAL fixes applied as inline revisions (W3-rev2, W4-rev2, W7-rev2). Meta-3 final verdict: SHIP. Total shipped: - medcare-rs: 14 commits, 13 files, ~1,865 LOC, 64 tests - lance-graph sprint-log: 21 commits (12 agent logs + 3 meta reviews + scaffolding + this synthesis) POLICY-1 / MEMBRANE-GATE-1 medcare-side seam: SHIPPED v1 - Mirror of smb-office-rs#29 with regulatory adaptations - Three TD caveats from PR #29 honestly carried forward - Topology I-1/I-2/I-3/I-4 invariants preserved Outstanding from Meta-3 (backlog): - HIGH #1: Action ops doc note (5 min) - HIGH #2: Tighten v1-limit assertions (10 min) - MEDIUM #3-#4: Policy name canonicalization + bench harness - LOW #5: TD-MEMBRANE-FIRST-VS-ANY test (vacuous in v1) Synthesis includes: - Findings summary (4 CRITICAL applied + 2 HIGH backlog) - Topology invariant preservation table - Upstream gaps surfaced (StepDomain verified, BMV-Ä retention, BtM Escalate) - Test posture per-crate - Recommended follow-up sprint scope (~half day) - What the cca2a pattern validated this run - Full branch state at sprint closure (commit lists for both repos) Ready for CI verification + PR to medcare-rs main.
This was referenced May 7, 2026
AdaWorldAPI
pushed a commit
that referenced
this pull request
May 7, 2026
Closes the governance loop for the #352 → #353 → #354 sequence on the lance-graph side, plus the 5-PR cross-repo coordinated landing of 2026-05-07 (lance-graph #352/#353/#354, OGIT #2, woa-rs #2, MedCare-rs #109). PR_ARC_INVENTORY.md prepended with minimal #354 entry; lock notes: - Append-only board hygiene survived 4 sequential prepends (incl. prior splat-osint) without any past-entry mutation. Confidence-line-only mutability policy is durable. - Cross-repo coordinated landing pattern documented as a recipe: lance-graph plans → OGIT TTL → consumer integration → governance close-out. LATEST_STATE.md table prepended with #354 row; "Last updated" advanced. No new types, plans, or knowledge docs in this commit — pure governance. Not opening a new PR for THIS commit (would be recursive governance-on-governance unless explicitly requested). https://claude.ai/code/session_01WevBiZ3jzVocu8fBpTY8sq
AdaWorldAPI
pushed a commit
that referenced
this pull request
May 16, 2026
…ix v1-temporal-corrupts-W3-Test-1 bug Codex review flagged two consistency gaps on PR #381 that would either produce uncompilable code or fail the regression suite for ordinary v1 data. Both addressed in this patch. W2 spec — pr-ce64-mb-2-causaledge64-v2.md - §9 Test Plan rewritten: removed test_g_slot_roundtrip, test_g_slot_max_no_w_contamination, and all g_slot()/with_g_slot()/ set_g_slot() assertions (no such API in v2 layout per L-3); with_routing signature corrected to (w: u8, t: TrustTexture); pack() signature corrected (no temporal arg per L-2); added test_inference_mantissa_signed_roundtrip, test_spare_isolation, test_mantissa_no_plasticity_contamination - §10 risk matrix: fixed "bits 46-48 are G slot bits" → bits 46-49 now hold 4b SIGNED mantissa, not G; not Option-C-conditional - §11 OQ-FORWARD-REFACTOR: same Option-C → Option-F correction W3 spec — pr-ce64-mb-2-pal8-nars-regression.md (CODEX P1 #2) - §3 Test 1 (pal8_v1_v2_round_trip_zero_default): root-cause fix — temporal=1023 in v1 sets bits 52-61 which v2 has reclaimed for W/lens/spare; under v2 decode those bits alias to non-zero W=63, truth=Murky. Test would FAIL on ordinary v1 data. Rewritten to use temporal=0 (the only safe binary-migration value) so byte-identical round-trip is provable. - §3 Test 1b (pal8_v1_nonzero_temporal_is_blocked_by_version_gate): NEW — proves the version gate is mandatory by asserting v1 temporal=1023 DOES produce non-zero W/truth under v2 (the failure mode) and that PAL8 v2 reader rejects the v1 blob with PalDecodeError::MissingVersionByte. - §3 Test 2 (pal8_v2_v2_round_trip_all_fields): dropped g_slot/ set_g_slot + temporal/set_temporal calls; rewrote isolation matrix to cover mantissa↔W↔truth↔spare (the four v2 reclaim-zone fields) - §3 Test 3 (pal8_round_trip_arbitrary, property test): same - §4 NarsTables Test 1: rewrote NarsEngine extraction claim (no temporal in v2; mantissa added); dropped set_g_slot(31); added set_spare(0b111) for full reclaim-zone isolation - §4 NarsTables Test 3 (nars_engine_to_from_causal_edge_isolates_new_fields): dropped g_slot references; added spare - §5 EdgeColumn test: dropped g_slot/temporal; added mantissa+spare - §8 W2-owned: corrected accessor list (inference_mantissa/w_slot/ truth/spare; no G_SHIFT) - §8 Agreement checklist: rewrote items 1-5 to Option F layout - §10 OQ-3: pack_v2 vs setter API updated to 4 setters (not 3) Process note: ~13 main-thread Edit calls in this fix; subagent Python-via-Bash workaround used for the final risk-matrix line fix after permission prompt feedback. Will follow up with settings.local.json wildcard syntax adjustment. https://claude.ai/code/session_01UwJuKqP828qyX1VkLgGJFS
AdaWorldAPI
pushed a commit
that referenced
this pull request
May 16, 2026
…ck semantic-routing bugs Codex review on PR #383 surfaced three semantic-routing bugs all sharing the root cause of "v1 API path bypasses v2 mantissa / reclaim-zone semantics". Same anti-pattern as the W3 spec codex P1 from PR #381. All three fixed + paired with regression tests. P1 #1 — forward() decoded weight.inference_type() (3-bit unsigned) even under v2, so a v2 edge built with `with_inference_mantissa(-1)` (Abduction direction) would read bits 46-48 as 0b111 = Reserved7 and dispatch through the synthesis/default branch instead of Abduction. Negative mantissas (Abduction, Counterfactual) silently produced wrong NARS truth propagation. Fix: under `causal-edge-v2-layout`, decode via `InferenceType::from_mantissa(weight.inference_mantissa())` for the match arm. Result re-stamped via `with_inference_mantissa( resolved_infer.to_mantissa())` so the sign bit (49) survives pack()'s v2 mantissa write (pack() needs the v1 enum value but to_mantissa() maps it through correctly — see P2 fix below). P1 #2 — set_temporal() unconditionally wrote bits 52-63 even under v2 where those bits are plasticity[2] + W-slot + lens + spare. The v1 learn() path calls set_temporal(current_time) after every observation; that call clobbered W-slot routing state and corrupted the reclaim zone for any edge that had been stamped via with_w_slot/ with_truth/etc. Same root cause as the pack() temporal-write bug fixed in commit ab39d01 — just a different setter path that wasn't gated. Fix: feature-gate set_temporal() the same way as pack(): under v2, the call is a complete no-op (the `t: u16` arg is silently dropped with documented migration pointer to chain-position + AriGraph Triplet.timestamp). learn() transitively becomes safe under v2 since the only reclaim-zone write was the set_temporal call. P2 — pack() under v2 wrote the raw `inference as u8` discriminant into bits 46-48 (3-bit mask). With the v1 enum: - Deduction=0, Induction=1, Abduction=2, Revision=3, Synthesis=4 - pack(Abduction) → bits 46-48 = 0b010, bit 49 = 0 - inference_mantissa() reads 4 bits as i4 → +2 - from_mantissa(+2) decodes as Induction, NOT Abduction Silent semantic drift on every v2 pack() call for any non-Deduction inference type. Fix: under v2, pack() writes `inference.to_mantissa() as i4` (4 bits including sign) so the round-trip pack→inference_mantissa→ from_mantissa preserves the semantic. The v1 branch keeps the original 3-bit discriminant write for back-compat. forward()'s final re-stamp (P1 #1 fix) covers the case where the resolved InferenceType needs to be re-encoded after composition. Three regression tests added to `v2_layout_tests.rs`: - `test_forward_decodes_negative_mantissa_under_v2` — Abduction via mantissa=-1 must NOT alias Reserved7 - `test_set_temporal_no_op_under_v2` — set_temporal(1023) on an edge with w=42/truth=Fuzzy/spare=0b101 must leave the raw u64 unchanged - `test_pack_uses_mantissa_mapping_under_v2` — pack(Abduction), pack(Counterfactual), pack(Intervention) all round-trip through inference_mantissa → from_mantissa with semantic identity preserved Test status post-fix: - v2 (default): 33 pass / 1 pre-existing fail (test_build_fast) - v1 (no features): 16 pass / 1 pre-existing fail - The 3 new regression tests prevent silent re-introduction https://claude.ai/code/session_01UwJuKqP828qyX1VkLgGJFS
AdaWorldAPI
pushed a commit
that referenced
this pull request
May 16, 2026
…ixes (CSI-7/8/9) The Opus honest meta-review (final of the 12+1 fleet) graded sprint-11 + Wave F at **B** (down from W-F10 Sonnet draft's B+) and surfaced 3 P0 integration gaps where worker output never reached the build path because lib.rs / workspace registration was orphaned between worker DONE and meta-review SPAWN. Fixed all three in this commit. W-Meta-Opus review (~/sprint-log-11/meta-review-opus.md, 161 lines) - Independent per-worker grades W-F1..W-F12 (W-F10 placeholders filled) - CSI-7..13 cross-cutting findings missed by Sonnet drafts - Sprint-11 grade: B (not B+) — Wave F integration discipline lapsed - Recommends promoting E-META-10 (v1-API-under-v2 alias) to iron rule in CLAUDE.md alongside I-SUBSTRATE-MARKOV / I-NOISE-FLOOR-JIRAK - Sprint-12 spawn recommendation: YES, conditional on Wave F + #386 merge P0 fix #1 — CSI-7: sigma-tier-router workspace registration - Added `crates/sigma-tier-router` to `Cargo.toml` workspace `members` - Removed the self-declared `[workspace]` table from `crates/sigma-tier-router/Cargo.toml` (it forced the crate into standalone mode, preventing parent-workspace inclusion) - Validation: `cargo test --manifest-path crates/sigma-tier-router/Cargo.toml` — 12/12 tests pass; clean cargo check P0 fix #2 — CSI-8: cognitive-shader-driver lib.rs gaps - Added `pub mod attention_mask;` and `pub mod attention_mask_actor;` at the top of the pub-mod block (alphabetically before bindspace) - W-F2 + W-F3 modules now reachable to downstream consumers; tests will execute on workspace cargo test P0 fix #3 — CSI-9: ndarray hpc/stream/mod.rs (cross-repo, this commit prepares ndarray for the companion change) - Edited `/home/user/ndarray/src/hpc/stream/mod.rs` to register `pub mod qualia;` + `pub mod splat_field;` alongside the existing `pub mod inference;` (W-F5 had registered itself; W-F4/W-F6 left orphans) - Re-exports: `QualiaI4Row`, `QualiaStream`, `SplatField`, `SplatFieldStream` - Validation: `cargo test --lib hpc::stream` in ndarray — **18/18 pass** (6 each × 3 streams) - The ndarray-side change requires a separate commit + push to the `/home/user/ndarray` repo (its own git history); main thread will land that as a sibling PR Aggregate Wave F test totals (verified via Opus review) - Rust impl workers (W-F1/2/3/4/5/6/7): 60 tests across 7 files - Governance/doc workers (W-F8/9/10/11/12): 5 markdown files, ~1500 LOC docs - Opus meta-review: 161 lines - Total Wave F LOC: ~5000 (code + docs + plans) Remaining gaps (per Opus review, NOT P0 but tracked) - W-F2's local `type MailboxId = u32` shadow alias (CSI-10) → keep for back-compat; sprint-12 refactor consolidates - E-META-10 promotion to iron rule → sprint-12 work - ndarray companion PR for CSI-9 → sibling commit https://claude.ai/code/session_01UwJuKqP828qyX1VkLgGJFS
AdaWorldAPI
pushed a commit
that referenced
this pull request
May 16, 2026
…tionMaskSoA + canonical MailboxId import Codex P2 review on PR #388 flagged that `AttentionMaskActor` is public but `AttentionMaskSoA` (the only production backend in the crate) doesn't implement `AttentionMaskBackend`. Downstream consumers can't add the impl themselves because they own neither the trait nor the SoA (Rust orphan rules), so `AttentionMaskActor::new(AttentionMaskSoA::new(...))` would force them to wrap in a local newtype. Fix #1 — production-backend impl in attention_mask_actor.rs Added `impl AttentionMaskBackend for crate::attention_mask::AttentionMaskSoA` with the four trait methods delegating to the existing inherent methods on AttentionMaskSoA. Now downstream consumers can wire the two directly: `AttentionMaskActor::new(AttentionMaskSoA::new(4))` works out of the box. Fix #2 — collapses CSI-10 from the W-Meta-Opus honest review The W-F2 worker had defined a local `pub type MailboxId = u32` in attention_mask.rs (Opus CSI-10 entry: "W-F2 used local MailboxId shadow alias"). Switched to `pub use lance_graph_contract::collapse_gate::MailboxId;` — same underlying u32 so all method signatures stay compatible, but now both attention_mask.rs and attention_mask_actor.rs reference the SAME canonical type and the trait impl in fix #1 can be added without type-mismatch concerns. Test status: 14/14 attention_mask + attention_mask_actor tests pass. Clean compile (modulo 2 pre-existing unused_mut warnings unrelated to this change). Branch rebased on main (post PR #385 merge) to pick up the ndarray hpc-extras feature flag that W-C1 added; this resolves the blake3 unresolved-crate compile failure that hit cognitive-shader-driver prior to rebase. https://claude.ai/code/session_01UwJuKqP828qyX1VkLgGJFS
This was referenced May 16, 2026
AdaWorldAPI
pushed a commit
that referenced
this pull request
May 18, 2026
…r-actor (Sprint 0) Adds two new stub crates from the four-repo integration plan as workspace-EXCLUDED scaffolds (additive contract shape; promoted to members in Sprint 1/2 once heavy deps land). * crates/lance-graph-tikv-provider/ (Glue #2, plan §5) TikvNodeTableProvider + TikvEdgeTableProvider stubs implementing datafusion::catalog::TableProvider + lance_graph_contract::provider markers. Bodies are Sprint 1 unimplemented!() with the trait shape pinned. * crates/cognitive-shader-actor/ (Glue #4, plan §6) CognitiveShaderActor<S> wrapping any SupervisableShader (from the new lance_graph_contract::actor module) as a ractor::Actor with ShaderMessage enum + ShaderSupervisor stub. Bodies are Sprint 2 unimplemented!() pending ractor::Actor signature confirmation. Both crates depend only on lance-graph-contract = "0.2" (path) plus their domain crates (tikv-client / ractor); no existing crate gains or loses a dep. Workspace check stays unaffected (excluded). Workers: LG-1, LG-2. Sprint 0 of the four-repo wave.
7 tasks
AdaWorldAPI
pushed a commit
that referenced
this pull request
May 18, 2026
Wave-5 worker W-INT-1. New excluded crate at `crates/four-repo-demo/`
that demonstrates three of the four glue surfaces working together:
* `cognitive-shader-actor::CognitiveShaderActor` wrapping a real
`SupervisableShader` (`SumShader`) — running-sum state via
`Arc<Mutex<i64>>`, payload is `arrow_array::RecordBatch`.
* `lance-graph-contract::actor::SupervisableShader` trait consumed
end-to-end (impl is real, not stub).
* `lance-graph-contract::ir::{Operator, OperatorTree, EngineHint,
Cardinality}` — builds a 3-node tree (RangeScan → Filter →
CognitiveApply) and computes total estimated cardinality.
The example at `examples/run_demo.rs`:
1. Spawns CognitiveShaderActor<SumShader> via ractor 0.15.13
2. Sends two ShaderMessage::Apply with single-row Int64 batches (5, 7)
3. Sends ShaderMessage::Drain
4. Prints the running sum (12) + the operator tree + cardinality estimate
Test results (cargo test --manifest-path crates/four-repo-demo/Cargo.toml):
* sum_shader_actor_running_sum ... ok
* operator_tree_has_three_nodes ... ok
* operator_tree_shape_correct ... ok
* operator_tree_total_cardinality ... ok
* 2 doc-tests pass
* All 6/6 tests pass
NOT demonstrated (and why, in the crate's lib.rs and README):
* Glue #1 surrealdb-ractor — needs a live SurrealDB
* Glue #2 lance-graph-tikv-provider — needs a TiKV cluster
* Glue #3 sea-orm-ractor — needs running Postgres + the derive
Workspace: added to `exclude` (heavy tokio + ractor + arrow deps).
.gitignore: `/crates/four-repo-demo/target/` to keep build artefacts
out of git.
Worker: W-INT-1. Wave-5 of the four-repo integration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add plan_err!, config_err!, exec_err! macros that use #[track_caller]
Bridge design: macros call plan_err_at()/config_err_at()/exec_err_at() which convert std::panic::Location to snafu::Location. This gives ergonomic macros while maintaining compatibility with 148 existing snafu error creation sites across 18 files.
https://claude.ai/code/session_016SeGMg1pgf1MqK8YWkedvV