feat: integrate ReservoirSample + rename Belichtungsmesser → LightMeter #9
Merged
Merged
Conversation
Structural changes: - Add ReservoirSample (Vitter's Algorithm R) for distribution-free quantile estimation. Works for any distribution shape. - Add empirical_bands/empirical_cascade computed from reservoir percentiles - Add auto-switch: when skewness/kurtosis indicate non-normality, band() and cascade_query() use empirical thresholds automatically - recalibrate() now resets Welford counters AND reservoir (fresh start) - Rename Belichtungsmesser → LightMeter, module → light_meter Confidence vs theory (12 tests, all pass): - Full-width rejection: Δ < 0.2% from normal distribution theory - 1/16 sample: matches predicted Z=k/4 variance inflation - 1/4 sample: matches predicted Z=k/2 variance inflation - Across 3 distribution shifts: average Δ = 0.17% - Bimodal detection: auto-switches to empirical (kurt=99 < 200 threshold) https://claude.ai/code/session_01Mcj8GxEtzmVba6RmuT7AjD
AdaWorldAPI
added a commit
that referenced
this pull request
May 6, 2026
…ITICAL fixes required) Meta-1 review surfaces 10 findings; 2 CRITICAL fixes block Round 2 opening: CRITICAL #1: Doctor.Anamnese Full predicate-write violates BMV-Ä §57 append-only → fix: empty writable_predicates, keep only "append" action CRITICAL #2: Receptionist clinical-blind fails safety (no Identity-read for allergy/triage lookup before scheduling) → fix: merge Patient permission to Detail-depth + 3 demographic writes, add Identity-read on Diagnosis + LabResult HIGH #3-#4 (defer to Round 3 gate.rs): Diagnosis finalize/retract Escalate + Patient anonymize/merge/delete Escalate (GDPR Art.17 + §35 BDSG) MEDIUM #5-#8 (backlog): Missing entities (Termin, Recall, ePA) + audit trail hook LOW #9-#10 (backlog): PKV/GKV modulation + dynamic reason strings Round 2 implications surfaced for W5/W8. Round 3 implications surfaced for W9/W12 (Escalate wrapping + §73 SGB V test). Concrete diff for W3-revision-2 included at end of file. Next commit: W3-revision-2 applies the two CRITICAL fixes.
AdaWorldAPI
added a commit
that referenced
this pull request
May 13, 2026
…rect misdiagnosed hpc-extras issue
S9-W1 (FIX-1 trybuild compile-fail probe):
* tests/zone_serialize_check_compile_fail.rs — replaced assert!(true) smoke
with subprocess-based probe asserting "D-CASCADE-V1-1 zone_serialize_check:"
abort signature. 112 LOC + 4 new fixture files.
* trybuild can't intercept cargo::error= from build-script exit(1); subprocess
form is equivalent rigour per the fallback path.
S9-W2 (D-PARITY-V2-10 classification doc comments):
* classification: comments added to external_intent.rs, ontology_dto.rs.
* cargo run -p dto-class-check exits 0 (was N/N FAIL).
S9-W3 (#355 follow-up #5 lance_cache Arrow schema bump):
* lance_cache.rs +209 LOC: 12 new columns persisting the MappingRow
cascade fields per D-CASCADE-V1-7 (cam_pq_code FixedSizeBinary(6),
base17_head FixedSizeBinary(8), palette_key UInt32, scent UInt8,
qualia FixedSizeList(Float32, 18), codec_meta UInt32, codec_edge UInt64,
thinking_style Utf8 nullable, attribute_sources_enc Utf8 with US/RS
encoding, plus 3 type-ref strings).
* 2 round-trip tests verify byte-identical equality across write/read.
* Backward-compat: lossy-allow (old v1 cache files default missing columns
to MappingRow::default() values).
* Collateral fix: pre-existing into_inner_unwrap_iter pattern in flush() +
set_last_root_checksum() replaced with vec![Ok(batch)].into_iter().
S9-W4 (sprint-7 W7 follow-on):
* namespace_registry.rs 20-line doc comment + 2 regression tests
confirming SMB.bson is a family-table-layer distinction, NOT a
registry-namespace-layer entry. Per OQ-4: enumerate("SMB.bson") returns
empty; seed_defaults() does not seed SMB.bson.
NDARRAY HPC-EXTRAS CORRECTION (per MedCare-rs#150):
* The "ndarray:master hpc-extras blocker" was MISDIAGNOSED in sprint-7.
ndarray master DOES ship hpc-extras as a default feature. Real root cause:
lance-graph consumer Cargo.toml entries setting default-features = false
without re-enabling hpc-extras.
* Crates patched: crates/lance-graph-planner/Cargo.toml,
crates/bgz-tensor/Cargo.toml
* ISSUES.md entry will be updated post-merge (permission-ask gate).
Tier B (#355 FIX-4 codebook_index bit-collision, FIX-5 trust_below_floor
wiring, per-row BindSpace.context_ids for driver.rs:311) deferred to
sprint-10 — couples to a BindSpace SoA layout change; planning spike required.
Tier C (#355 follow-ups #7/#8/#9 — BioPortal validation, 80 MedCare-rs
tables, 25 MySQL transcode stubs) is cross-repo (OGIT / MedCare-rs side),
not lance-graph's hill.
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Structural changes:
quantile estimation. Works for any distribution shape.
band() and cascade_query() use empirical thresholds automatically
Confidence vs theory (12 tests, all pass):
https://claude.ai/code/session_01Mcj8GxEtzmVba6RmuT7AjD