fix(knowledge): tier-0 canonical pattern letters (post-#358 correction; Pattern A is SPO-G design phase, not 'OGIT Triangle shipped')#359
Conversation
…rn A is SPO-G u32 DESIGN PHASE, NOT 'OGIT Triangle Shipped'
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dff65796b5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| | **F** | **ractor/BEAM Supervisor in Zone 2/3** | 🚧 **DESIGN PHASE — actor shape PROVEN** | TD-RACTOR-SUPERVISOR-5. The handler-arm shape is mechanical from `crates/cognitive-shader-driver/src/grpc.rs` tonic service trait | | ||
| | **G** | **Best-Practice Thinking Inheritance per OGIT-G** | 🚧 **DESIGN PHASE** | The 12-style base codebook in `crates/p64-bridge/src/lib.rs::STYLES` is the substrate. The per-G inheritance chain (DOLCE root → Healthcare/Gotham/SMB/CRM extensions) is what's missing | | ||
| | **H** | **Switchable Cognitive Vessel** | ✅ **SHIPPED** | `crates/p64-bridge/src/lib.rs::cognitive_shader::CognitiveShader` (8 predicate planes + bgz17 PaletteSemiring + HHTL cascade + `deduce_path`). Doc says: *"No POPCNT. No Hamming. Distance is PRECOMPUTED in the codebook. The mask gates access. The table provides the answer. O(1)."* | | ||
| | **I** | **Implicit Cognition (continuous, not request-driven)** | ✅ **SHIPPED** | `crates/lance-graph-contract/src/cycle_accumulator.rs` (PR #337) — the per-cadence flush gate that lets L1 fire continuously and L2 pull on threshold | |
There was a problem hiding this comment.
Keep Pattern I marked as open until it is wired
When future Pattern I work is triaged from this table, marking it as shipped will cause the ractor/background flush integration to be skipped even though only the pure CycleAccumulator helper exists: repo-wide rg CycleAccumulator only finds the contract module and its tests, and the authoritative master plan still lists Pattern I as open with the flush policy unspecified. Please keep this as open/partially shipped until an actual background L1 actor or caller wires the accumulator into continuous cycles.
Useful? React with 👍 / 👎.
Critical follow-up to merged PR #358
The Tier-0 Pattern Recognition doc landed in PR #358 (merged) with a non-canonical pattern-letter scheme that mislabels several DESIGN-PHASE patterns as SHIPPED. Most critically:
This is dangerous because the same doc tells readers "don't build shipped patterns". A future agent reading it would skip TD-OGIT-G-SLOT-1 work (the foundational SPO-G slot for the entire OGIT-G overlay).
What this PR fixes
Rewrites
.claude/knowledge/tier-0-pattern-recognition.md(~22 KB → ~26 KB) with:TECH_DEBT.mdfor design-phase workWhy a separate PR
PR #358 merged before this fix could land. Rather than direct-commit to main, this PR exists for visibility — the tier-0 doc is the load-bearing entry point for all future architectural work; the correction deserves its own review trail.
Test plan
🧠 Future agents who read tier-0 first will now correctly route DESIGN-PHASE work through the TD entries instead of skipping it.
🤖 Generated by Claude Code