docs(specs): sprint-3 Tier-1 implementation specs (11 PR-X-1 + sequencing + smoke test + consumer template)#360
Conversation
…more open Qs (TD-OGIT-G-SLOT-1)
…mple; ~100-150 LOC vs medcare ~1865 LOC; 12-18x reduction)
…CTOR-SUPERVISOR-5)
Tier-3 specialization spec. ThinkingAtom32x4 (16-byte fingerprint, 32x4-bit dims) + nibble-min-sum cosine_int4 + knn_thinking_styles top-K over the 12-entry p64-bridge::STYLES codebook. Pattern G fallback when OGIT lacks a best-practice for a new domain. TD-INT4-32D-ATOMS-6.
Decisions, dependency call-out (parallel-landable with PR-B-1), brutally-honest self-review, protocol notes (pygithub-first, token quotes stripped).
…THINK-10, TD-DEEPNSM-NSM-11)
…e-graph; original W9 pushed to ada-consciousness)
…atterns + critical-path sequencing + smoke test + consumer template
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b07858a0f7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| for g in registry.active_g_list() { | ||
| let bundle = registry.resolve(g) | ||
| .ok_or_else(|| ActorProcessingErr::from(format!("inert g={}", g)))?; | ||
| let pointer = bundle.consumer_pointer.as_ref() | ||
| .ok_or_else(|| ActorProcessingErr::from(format!("g={} has no ConsumerPointer", g)))?; |
There was a problem hiding this comment.
Skip inert bundles when spawning actors
When the registry contains the required inert bundles from the manifest spec (for example DOLCE and FMA have consumer_pointer = None), this loop treats the missing pointer as an ActorProcessingErr, so CallcenterSupervisor::pre_start aborts before spawning any real consumer. The smoke-test spec explicitly expects DOLCE to have no pointer while Healthcare still spawns, so the supervisor needs to iterate only bundles with a consumer pointer (or continue on inert Gs) rather than failing on them.
Useful? React with 👍 / 👎.
| reg.insert(2, ContextBundle::healthcare_v1( | ||
| #[cfg(feature = "module-medcare")] | ||
| Some(ConsumerPointer::new::<medcare_rs::MedCareActor>()), | ||
| #[cfg(not(feature = "module-medcare"))] | ||
| None, |
There was a problem hiding this comment.
Keep consumer actor types out of the contract crate
Emitting medcare_rs::MedCareActor from lance-graph-contract means the contract crate must depend on the consumer crate whenever module-medcare is enabled, but the consumer template makes each consumer depend back on lance-graph-contract; enabling the feature therefore creates a Cargo dependency cycle and the required feature-enabled build cannot compile. The concrete actor registration needs to live in an outer crate/binary or use a callback/registry mechanism instead of generated code inside the contract crate.
Useful? React with 👍 / 👎.
Spec corrections appended (post-review, pre-merge)Two real architectural defects flagged during review have been corrected via append-only sections at the end of the affected specs: Defect 1 — PR-F-1 supervisor inert-bundle handling
Defect 2 — PR-E-1 Cargo dependency cycleBuild script in Why append-onlyBoth PR-F-1 and PR-E-1 specs preserve their original content unchanged; corrections are appended sections at the end. The engineer picking up implementation reads the correction sections as authoritative for the contested sub-areas. This matches the APPEND-ONLY governance pattern used across Affected sister specs
Both correction commits land on the sprint-3 branch this PR tracks; no separate fix-PR needed. |
…fixes-v2 fix(specs): PR-F-1 supervisor inert-bundle skip + PR-E-1 Cargo cycle (post-#360 corrections)
…ables in INTEGRATION_PLANS.md
…trate-recognition docs(specs+board): post-#360 substrate-recognition sweep — 3 spec re-scopes + cross-source matrix + sprint prompt template + board hygiene
Summary
Sprint-3: convert the 7 DESIGN-PHASE patterns (A, B, C, D, E, F, J) and the 3 trivia closures from sprint-2's TD entries into PR-ready implementation specs. Engineer can now execute Tier-1 in ~6 working days.
Predecessor
PR #358 (sprint-2 architecture synthesis) named the 15 patterns A-O and recognized ~80% as already shipped. PR #359 corrected the tier-0 canonical pattern letter assignment. This PR (sprint-3) converts the remaining ~20% into engineer-ready specs.
What this PR does NOT change
What this PR adds
11 PR-X-1 specs (
.claude/specs/)sprint-3-execution-plan.mdpr-a-1-spo-g-u32-slot.mdpr-b-1-context-bundle.mdpr-c-1-generic-bridge.mdpr-d-1-fma-owl-hydrator.mdpr-e-1-manifest-modules.mdpr-f-1-ractor-supervisor.mdpr-j-1-int4-32d-atoms.mdtrivia-prs-bundle.mdconsumer-crate-template.mdogit-g-smoke-test.mdsprint-3-pr-graph.mdTotal LOC for sprint-4+ implementation: ~2,470 LOC across ~10 PRs.
Coordination (
.claude/board/sprint-log-3/)SPRINT_LOG.md(main-thread scaffolding pre-written before agent spawn)agents/agent-W{1..12}.md(12 per-agent append-only logs)meta-1-review.md(brutally honest review)sprint-summary.md(closure)Critical path (sequenced PR order, per W10 sequencing analysis)
Critical path: ~11 working days serial / ~6 working days parallelized.
Architectural validation milestones (in execution order)
Corrections applied during sprint
AdaWorldAPI/ada-consciousnessinstead ofAdaWorldAPI/lance-graph; deferred toGITHUB_REPOenv var). Main thread recovered the spec verbatim and pushed to lance-graph via pygithub. Provenance note prepended for archaeology. Same wrong-repo failure mode as W7 in sprint-2. Future sprints should add explicit guardrail.CCA2A protocol upgrades validated
Test plan
repo.get_contents)Notes
trivia-prs-bundle.md3 quick wins (PR-CAM-DIST 1-line, PR-ADJ-THINK ~30 LOC, PR-DEEPNSM-NSM ~30 LOC + 5 deletes) can ship in parallel with the critical path; they close TD-CAM-DIST-REGISTRATION-9, TD-ADJ-THINK-EXPOSE-10, TD-DEEPNSM-NSM-COLLAPSE-11 and reframe the corresponding ledger rows.Branch state
6dab08ac(post W9-rev2; meta + summary commits land on top)🧠 Engineer can now execute Tier-1 in ~6 parallelized working days. PR-B-1 first; everything else fans out from there.
🤖 Generated by Claude Code