Easy networks#128
Merged
Merged
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Merged
cnellington
approved these changes
Oct 28, 2022
cnellington
left a comment
cnellington
left a comment
Collaborator
There was a problem hiding this comment.
LGTM! NOTMAD should be ready for an sklearn wrapper as well after the recent updates to dev.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added Easy interfaces to 2 network classes: Correlation networks and Markov networks.
Usage is shown in
test_networks.pyand a briefeasy_networks_demo.ipynb.Bayesian Networks are not yet integrated due to the difference in NOTMAD using a CX_DataModule rather than dataloaders.
Also bumps pylint score to 7.95 and solves #95 .