DAGs Cleanup#129
Merged
Merged
Conversation
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleaned the dags module to use similar patterns as contextualized.regression.
Setting up for a contextualized.graphs module including correlation and Markov networks.
Removed datamodules, baselines, and callbacks files from the dags module (check the commits before this PR if there's any need for these in the future).
Note: This NOTMAD version converges to the true parameters in tests, but requires more epochs (50 vs. 5). Possibly because dynamic alpha/rho was being called twice per epoch in previous tests? Will be looking into this, but making this PR so that #128 can continue.