chore(deps): update @relaycast/sdk to 4.0 in @agent-relay/sdk + cli#1133
Conversation
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (4)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughThree Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
CHANGELOG.md (1)
23-23: ⚡ Quick winMake the Unreleased changelog bullet concise and user-impact-first.
Line 23 currently mixes user-facing change with internal implementation detail (status-model and override mechanics). Keep this as one short impact statement.
Suggested edit
-- `@agent-relay/sdk` and `@agent-relay/cli` now build against `@relaycast/sdk` 4.0 (durable-delivery status model `queued|delivered|acked|failed|dead_lettered`); a workspace override pins the dependency to a single 4.0 line across the tree. +- `@agent-relay/sdk` and `@agent-relay/cli` now use `@relaycast/sdk` 4.0.As per coding guidelines,
CHANGELOG.mdshould keep[Unreleased]entries concise, impact-first, and omit implementation details.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@CHANGELOG.md` at line 23, Simplify the changelog entry on line 23 to be concise and user-impact-first. Remove the internal implementation details about the durable-delivery status model (queued|delivered|acked|failed|dead_lettered) and workspace override mechanics, as these are not relevant to end users. Keep only the core user-facing impact: that `@agent-relay/sdk` and `@agent-relay/cli` now build against `@relaycast/sdk` 4.0.Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@CHANGELOG.md`:
- Line 23: Simplify the changelog entry on line 23 to be concise and
user-impact-first. Remove the internal implementation details about the
durable-delivery status model (queued|delivered|acked|failed|dead_lettered) and
workspace override mechanics, as these are not relevant to end users. Keep only
the core user-facing impact: that `@agent-relay/sdk` and `@agent-relay/cli` now
build against `@relaycast/sdk` 4.0.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 8bde296f-3329-416d-b7c2-9d084be4b7a2
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (4)
CHANGELOG.mdpackage.jsonpackages/cli/package.jsonpackages/sdk/package.json
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 03967f3630
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| }, | ||
| "dependencies": { | ||
| "@relaycast/sdk": "^3.1.1" | ||
| "@relaycast/sdk": "^4.0.0" |
There was a problem hiding this comment.
Map Relaycast 4 delivery statuses before bumping
With @relaycast/sdk 4 the durable-delivery API now reports the queued|delivered|acked|failed|dead_lettered status model, but the SDK adapter still only recognizes the old accepted|delivered|deferred|failed values in packages/sdk/src/messaging/normalize.ts and defaults unknown statuses to queued. When an agent acks a delivery or reads a dead-lettered row, inbox.*/deliveries.* will therefore surface a terminal item as queued, which can make durable-delivery consumers retry or misreport already-final deliveries; please update the status normalization alongside this dependency bump.
Useful? React with 👍 / 👎.
03967f3 to
5680e1d
Compare
Bump @relaycast/sdk ^3.1.1 -> ^4.0.0 in packages/sdk and packages/cli. Also fix a stale sibling pin: packages/evals pinned @agent-relay/harness-driver '8.6.0' (an exact PUBLISHED version) while the workspace is 8.7.2 — so npm fetched the published 8.6.0 from the registry instead of symlinking the local package, dragging in @agent-relay/sdk@8.6.0 -> @relaycast/sdk@3.1.1 and preventing a single @relaycast/sdk from hoisting. Repin to 8.7.2 (matching every other workspace cross-dep) so it uses the local harness-driver (which pulls no @relaycast/sdk); @relaycast/sdk@4.0.0 then hoists cleanly with no override. relay's SDK only consumes RelayCast/RelayError/options from @relaycast/sdk, none of which 4.0's breaking changes touch — build:core clean, full suite (924) passes.
5680e1d to
a010f73
Compare
What
Bumps
@relaycast/sdk^3.1.1→^4.0.0in@agent-relay/sdkand@agent-relay/cli(relay's two consumers).The real root cause (no override needed)
The naive bump broke one test because of a version skew:
packages/evalspinned@agent-relay/harness-driver: "8.6.0"— an exact published version, while the workspace is8.7.2. The repo convention is to pin siblings at the exact workspace version so npm symlinks the local package;8.6.0 ≠ 8.7.2made npm fetch the published8.6.0from the registry, dragging in@agent-relay/sdk@8.6.0 → @relaycast/sdk@3.1.1and preventing a single@relaycast/sdkfrom hoisting. That left relay's own SDK on a nested4.0.0the MCP-startup test's mock couldn't intercept.Fix: repin
evalsto8.7.2(matching every other workspace cross-dep) so it uses the localharness-driver— which pulls no@relaycast/sdk.@relaycast/sdk@4.0.0then hoists cleanly. No override.Safety
relay's SDK only uses
RelayCast/RelayError/options from@relaycast/sdk— none touched by 4.0's breaking changes.build:coreclean, full suite 924 passing.🤖 Generated with Claude Code