Pin Relaycast SDK for publish installs#1173
Conversation
There was a problem hiding this comment.
Code Review
This pull request pins the @relaycast/sdk dependency to the exact version 4.1.1 in both the CLI and SDK packages to prevent publish-time installation failures from resolving unavailable sibling @relaycast/types versions. The reviewer advises against pinning dependencies in library packages like @agent-relay/sdk due to dependency deduplication issues for downstream consumers, suggesting instead to keep the caret range in the library package and handle pinning via overrides or solely within the CLI package.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| }, | ||
| "dependencies": { | ||
| "@relaycast/sdk": "^4.1.1" | ||
| "@relaycast/sdk": "4.1.1" |
There was a problem hiding this comment.
Pinning dependencies in a library package (like @agent-relay/sdk) is generally discouraged as it prevents npm/yarn from deduplicating dependencies for downstream consumers. If a consumer project uses a different version of @relaycast/sdk (e.g., 4.1.2), it will force duplicate installations of @relaycast/sdk and can lead to type mismatches or runtime issues if the SDK relies on singletons or global state.
If the goal is to prevent publish-time floating of dependencies during the build/publish process, consider using npm overrides (or yarn resolutions) in the root package.json or pinning it only in the CLI/application package (packages/cli/package.json), while keeping a caret range (e.g., ^4.1.1) in the library's package.json.
| "@relaycast/sdk": "4.1.1" | |
| "@relaycast/sdk": "^4.1.1" |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (2)
📝 WalkthroughWalkthroughPins the ChangesPin
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Working tree is clean. My review is complete. The PR is a clean, minimal, mechanical dependency-pin change that I verified end-to-end. SummaryPR #1173 pins Verification performed:
No code edits made — the change is correct and mechanical; nothing required fixing. Advisory Notes
Addressed comments
The PR is correct and self-contained, but I cannot confirm from this sandbox that all required CI checks have completed and passed or that GitHub reports it mergeable (those are post-harness, cloud-reported states). I am therefore not printing READY. |
|
ℹ️ pr-reviewer: review only — no file changes were applied to the PR (nothing to commit after review). The notes below are advisory and were not pushed. CI uses Important check: the committed lockfile already had pre-existing This is a clean, correct, narrowly-scoped PR. My review is complete. Review SummaryPR #1173 pins Verdict: Correct and well-scoped. No code changes needed. What I verified against the current checkout:
What I did NOT change:
Addressed comments
Advisory Notes
This is a mechanical, low-risk dependency pin that is internally consistent and matches its stated intent. It needs a human to merge, but I cannot confirm CI status or mergeability from this sandbox, so I am not printing the ready signal. |
|
Closing this pinning approach. @relaycast/types@4.1.2 is now published, so the replacement no-pin fix is #1174, which bumps the caret range to ^4.1.2 and refreshes the lockfile. |
Summary
Validation