fix(dashboard): enable mobile touch scrolling in log viewers#137
Merged
Conversation
- XTermLogViewer: Change overflow-hidden to overflow-auto on mobile, keeping overflow-hidden on md+ breakpoints where xterm.js handles internal scrolling - LogViewer inline mode: Add touch-pan-y for consistent touch behavior - Both components: Add WebkitOverflowScrolling: 'touch' for iOS momentum scrolling Fixes mobile users being unable to scroll through logs due to overflow-hidden blocking touch scroll gestures. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enable native touch scrolling for log viewers on mobile devices while preserving desktop xterm.js scrolling behavior.
Changes
XTermLogViewer.tsx: Changed container from
overflow-hiddentooverflow-auto md:overflow-hiddenwithtouch-pan-yclass and-webkit-overflow-scrolling: touchstyle. This enables smooth momentum scrolling on mobile while desktop users still benefit from xterm.js internal scrolling.LogViewer.tsx (inline mode): Added
touch-pan-yclass and-webkit-overflow-scrolling: touchto ensure consistent iOS/Android momentum scrolling.Test Plan
Related
Closes #bd-mobile-log-scroll