Skip to content

fix caching#737

Merged
AlexInLog merged 2 commits into
v2from
fix_caching
Feb 15, 2026
Merged

fix caching#737
AlexInLog merged 2 commits into
v2from
fix_caching

Conversation

@AlexInLog

@AlexInLog AlexInLog commented Feb 15, 2026

Copy link
Copy Markdown
Owner

Summary by CodeRabbit

  • Chores
    • Updated GitHub Actions workflows to use the latest cache action versions (v5) for improved CI/CD performance and consistency.
    • Cleaned up unused configuration from the build dependency system.

@coderabbitai

coderabbitai Bot commented Feb 15, 2026

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

GitHub Actions workflows are updated to use cache actions v5 instead of v4, with new cache persistence logic added to ci v2.yml. A commented-out protobuf dependency line is removed from conanfile.py.

Changes

Cohort / File(s) Summary
GitHub Actions Cache Updates
.github/workflows/analyzers.yml, .github/workflows/ci v2.yml
Updated cache actions from v4 to v5; ci v2.yml additionally introduces actions/cache/restore@v5 for retrieval and actions/cache/save@v5 for persistence, plus a new Force Save Cache step with composite key generation for Conan dependencies cache.
Build Dependencies
conanfile.py
Removed commented-out protobuf dependency line; all other requirements unchanged.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

  • try to speedup cache #663: Modifies cache steps in the same workflow files with adjustments to cache keys and conditional logic alongside the v5 upgrade.
  • try fix caching #735: Modifies CI workflow cache steps and updates protobuf-related lines in conanfile.

Poem

🐰 Our caches now hop on v5's swift feet,
With saves and restores, the deps are complete,
A commented ghost fades from the conan file,
Workflows now gleam with improved style! ✨

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix caching' clearly and directly describes the main objective of the pull request, which focuses on updating cache configurations across multiple workflow files and removing a commented dependency.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Merge Conflict Detection ✅ Passed ✅ No merge conflicts detected when merging into v2

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix_caching

No actionable comments were generated in the recent review. 🎉

🧹 Recent nitpick comments
.github/workflows/ci v2.yml (1)

115-120: Consider using actions/cache/restore@v5 (restore-only) for the consumer jobs.

The sanitize and tests jobs use actions/cache@v5 (combined restore+save), which means they'll attempt to save the cache again at job completion — even though cache_deps already persisted it. Since cache keys are immutable, the redundant save is a no-op, but switching to actions/cache/restore@v5 would be more intentional and avoid the unnecessary save attempt, consistent with the split pattern in cache_deps.

♻️ Suggested change for sanitize (line 116) and tests (line 193)
     - name: cache deps
-      uses: actions/cache@v5
+      uses: actions/cache/restore@v5
       with:

Apply to both the sanitize job (line 116) and the tests job (line 193).

Also applies to: 192-197


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@AlexInLog AlexInLog merged commit 8ea0402 into v2 Feb 15, 2026
38 checks passed
@AlexInLog AlexInLog deleted the fix_caching branch February 15, 2026 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant