[Common] RecoDecay: Templatize MC particle. - #11854
Merged
Merged
Conversation
mfaggin
requested review from
a team,
alibuild,
ddobrigk,
iarsene,
jgrosseo and
ktf
as code owners
July 1, 2025 09:27
|
O2 linter results: ❌ 21 errors, |
github-actions
Bot
changed the title
ddobrigk
changed the title
ddobrigk
approved these changes
Jul 1, 2025
ddobrigk
enabled auto-merge (squash)
July 1, 2025 09:45
vkucera
changed the title
vkucera
approved these changes
Jul 1, 2025
vkucera
disabled auto-merge
July 1, 2025 11:23
vkucera
enabled auto-merge (squash)
July 1, 2025 11:23
jpxrk
pushed a commit
to jpxrk/O2Physics
that referenced
this pull request
Jul 16, 2025
Co-authored-by: Mattia Faggin <mfaggin@cern.ch>
prottayCMT
pushed a commit
to prottayCMT/O2Physics2024
that referenced
this pull request
Jul 18, 2025
Co-authored-by: Mattia Faggin <mfaggin@cern.ch>
JimunLee
pushed a commit
to JimunLee/O2Physics
that referenced
this pull request
Jul 22, 2025
Co-authored-by: Mattia Faggin <mfaggin@cern.ch>
vojmach
pushed a commit
to vojmach/O2Physics
that referenced
this pull request
Jul 23, 2025
Co-authored-by: Mattia Faggin <mfaggin@cern.ch>
jloemker
pushed a commit
to jloemker/O2Physics
that referenced
this pull request
Nov 11, 2025
Co-authored-by: Mattia Faggin <mfaggin@cern.ch>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Data type for
particleIchanged in the template oneT.In the method
getMatchedMCRecthe candidate daughter particles are retrieved withauto particleI = arrDaughters[iProng].mcParticle();, i.e.particleIis always of typeMcParticles::iterator. This means that the current version of the code works if and only ifT == McParticles, but it does not work if it is something else, e.g.soa::Join<McParticles, <something_else> >. This fails e.g. in thegetMotherfunction, were the 2nd argument must always be aniteratorof the 1st one.