Fix PHP 7.4 warnings/notices#113
Merged
Merged
Conversation
…errors later in this method
Closed
GaryJones
added
the
type: maintenance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I made the same changes to this file that were made in the WordPress.org plugin directory's version. See this Trac ticket. Then I corrected a few additional instances of curly syntax because WordPress.org's version of this class is newer. This all seems to work nicely. My ads still load, and the warning/notices no longer appear in my logs while running PHP 7.4. If merged, this fixes #112.
It's not clear to me if this plugin has been abandoned, so it doesn't seem like the time to upgrade the Markdown parser itself.