Skip to content

Phpcs fixes#115

Closed
trepmal wants to merge 3 commits into
developfrom
phpcs-fixes
Closed

Phpcs fixes#115
trepmal wants to merge 3 commits into
developfrom
phpcs-fixes

Conversation

@trepmal
Copy link
Copy Markdown
Contributor

@trepmal trepmal commented Jun 4, 2021

This PR covers the current PHPCS ruleset, as well as addresses some php7.4 compat.

However, should probably give priority to reviewing these exisiting PRs which cover much if not all of the same.
#107
#110
#113

Comment thread ad-code-manager.php
@GaryJones GaryJones added this to the 0.6 milestone Mar 14, 2022
@GaryJones GaryJones added the type: maintenance Routine maintenance and code quality improvements label Mar 14, 2022
@GaryJones GaryJones changed the base branch from master to develop March 14, 2022 17:02
GaryJones added a commit that referenced this pull request Mar 15, 2022
Inspired by @trepmal's changes in #115.
@GaryJones GaryJones deleted the phpcs-fixes branch March 15, 2022 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: maintenance Routine maintenance and code quality improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants