Skip to content

chore: run setupEpoch separately #13984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LHerskind merged 1 commit into from
May 7, 2025
Merged

chore: run setupEpoch separately #13984

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion l1-contracts/bootstrap.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ function validator_costs {
report="gas_benchmark.new.md" # will be overwritten each run

# keep ONLY these functions, in this order
wanted_funcs="forward submitEpochRootProof"
wanted_funcs="forward setupEpoch submitEpochRootProof"

# one label per numeric column (use | to separate)
labels='Min|Avg|Median|Max|# Calls'
Expand Down
22 changes: 14 additions & 8 deletions l1-contracts/gas_benchmark.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,20 @@
Function | Metric | No Validators (gas/tx) | 100 Validators (gas/tx) | Δ Gas (gas/tx) | % Overhead
-------------------------+---------+------------------------+-------------------------+------------------------+-----------------
forward | Min | 280145 (778.18) | 614490 (1706.92) | 334345 (928.74) | 119.35%
forward | Avg | 288582 (801.62) | 679903 (1888.62) | 391321 (1087.00) | 135.60%
forward | Median | 285127 (792.02) | 619574 (1721.04) | 334447 (929.02) | 117.30%
forward | Max | 349164 (969.90) | 2104890 (5846.92) | 1755726 (4877.02) | 502.84%
forward | Min | 290580 (807.17) | 619528 (1720.91) | 328948 (913.74) | 113.20%
forward | Avg | 298348 (828.74) | 627316 (1742.54) | 328968 (913.80) | 110.26%
forward | Median | 296910 (824.75) | 625887 (1738.58) | 328977 (913.83) | 110.80%
forward | Max | 310600 (862.78) | 639564 (1776.57) | 328964 (913.79) | 105.91%
forward | # Calls | 100 | 100 | 0 | 0.00%
-------------------------+---------+------------------------+-------------------------+------------------------+-----------------
submitEpochRootProof | Min | 858815 (74.55) | 858815 (74.55) | 0 (0.00) | 0.00%
submitEpochRootProof | Avg | 876459 (76.08) | 870759 (75.59) | -5700 (-0.49) | -0.65%
submitEpochRootProof | Median | 858827 (74.55) | 858827 (74.55) | 0 (0.00) | 0.00%
submitEpochRootProof | Max | 911736 (79.14) | 894636 (77.66) | -17100 (-1.48) | -1.88%
setupEpoch | Min | 40747 (3.54) | 37766 (3.28) | -2981 (-0.26) | -7.32%
setupEpoch | Avg | 41849 (3.63) | 99641 (8.65) | 57792 (5.02) | 138.10%
setupEpoch | Median | 40747 (3.54) | 37766 (3.28) | -2981 (-0.26) | -7.32%
setupEpoch | Max | 67061 (5.82) | 1583400 (137.45) | 1516339 (131.63) | 2261.13%
setupEpoch | # Calls | 100 | 100 | 0 | 0.00%
-------------------------+---------+------------------------+-------------------------+------------------------+-----------------
submitEpochRootProof | Min | 858825 (74.55) | 858825 (74.55) | 0 (0.00) | 0.00%
submitEpochRootProof | Avg | 876477 (76.08) | 870777 (75.59) | -5700 (-0.49) | -0.65%
submitEpochRootProof | Median | 858837 (74.55) | 858837 (74.55) | 0 (0.00) | 0.00%
submitEpochRootProof | Max | 911770 (79.15) | 894670 (77.66) | -17100 (-1.48) | -1.88%
submitEpochRootProof | # Calls | 3 | 3 | 0 | 0.00%
-------------------------+---------+------------------------+-------------------------+------------------------+-----------------
2 changes: 1 addition & 1 deletion l1-contracts/test/benchmark/happy.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,7 +318,7 @@ contract BenchmarkRollupTest is FeeModelTestPoints, DecoderBase {
// and part of the `empty_block_1.json` file. The block cannot be proven, but it
// will be accepted as a proposal so very useful for testing a long range of blocks.
if (rollup.getCurrentSlot() == nextSlot) {
TestPoint memory point = points[nextSlot.unwrap() - 1];
rollup.setupEpoch();

Block memory b = getBlock();
address proposer = rollup.getCurrentProposer();
Expand Down