chore: run setupEpoch separately#13984
Merged
Merged
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
LHerskind
force-pushed
the
lh/gas-benchmarks
branch
from
0fc1650 to
4dc8c2a
Compare
LHerskind
force-pushed
the
lh/gas-benchmarks
branch
from
4dc8c2a to
d4ebfcd
Compare
LHerskind
force-pushed
the
lh/gas-benchmarks
branch
from
d4ebfcd to
0aedec3
Compare
just-mitch
approved these changes
May 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the seed snapshots pr #13577 there was a change that mean that
getCurrentProposercan end up running thesetupEpoch(reducing number of different flows etc). However, that meant that when we were running our benchmark test to get some gas numbers, we never end up including the gas spent to setup the epoch. To address, we are now explicitly callingsetupEpochsuch that we get some neat measurements for it, also making it clear when changes are made that impact the sampling.A nice side effect, is that it more simply allow us to do the proper amortized cost for sampling as the propose is for 360 tx, but sampling is for 11520 (32 * 360). This new setup makes it more simple to see the direct impact from the sampling on tx costs etc.