feat: merge-train/barretenberg#15509
Merged
Merged
Conversation
* Our basic binary ops produce a new gate iff both operands are witnesses. Most of the implementations contained deeply branched logic that is now replaced with simple `int` arithmetic that looks more robust and is much easier to read. * Added documentation in various places. The constraints are made more explicit * Removed redundant assignments * Re-worked the test suite. Now all basic ops and functions are tested for all combinations of flags (`is_constant`, `witness_bool`, `witness_inverted`). Added missing tests, checked various edge cases. * Removed a couple of tests that seemed less expressive * Removed `must_imply()` method for a vector of implications, as it is not used anymore * Fixed a `normalize()` regression - previously it wouldn't check if (`witness_inverted == false`) and would normalize a witness `bool_t` even if the condition is satisfied. It is the reason for the VK changes
We enhance the Shplonk verifier api so that it can efficiently handle openings of polynomials that are linearly dependent --------- Co-authored-by: AztecBot <tech@aztecprotocol.com> Co-authored-by: ludamad <adam.domurad@gmail.com> Co-authored-by: Suyash Bagad <suyash@aztecprotocol.com> Co-authored-by: sergei iakovenko <105737703+iakovenkos@users.noreply.github.com> Co-authored-by: Jonathan Hao <jonathan@aztec-labs.com> Co-authored-by: ledwards2225 <98505400+ledwards2225@users.noreply.github.com>
… on rebase logic (#15508)
The `bit_array` stdlib primitive is not used in the production code --> deleted Had to change a couple of headers that included `bit_array` to access`plookup` or `uint`. Fixed some misleading comments in a couple of fuzzers
`ECCVM-` and `Translator-` `RecursiveFlavors` are only used with `UltraCircuitBuilder`, which allows us to decouple them and the corresponding `RecursiveVerifiers` from `Flavor` template parameter.
Collaborator
|
🤖 Auto-merge enabled after 4 hours of inactivity. This PR will be merged automatically once all checks pass. |
danielntmd
pushed a commit
to danielntmd/aztec-packages
that referenced
this pull request
Jul 16, 2025
See [merge-train-readme.md](https://github.com/AztecProtocol/aztec-packages/blob/next/.github/workflows/merge-train-readme.md). chore: stdlib bool internal audit (AztecProtocol#15070) feat: improve Shplonk api (AztecProtocol#15422) fix(merge-train): don't queue merge if merge-train failed queue, pass on rebase logic (AztecProtocol#15508) chore: nuke bit array (AztecProtocol#15522) chore: remove template parameters (AztecProtocol#15530) --------- Co-authored-by: AztecBot <tech@aztecprotocol.com> Co-authored-by: sergei iakovenko <105737703+iakovenkos@users.noreply.github.com> Co-authored-by: federicobarbacovi <171914500+federicobarbacovi@users.noreply.github.com> Co-authored-by: Suyash Bagad <suyash@aztecprotocol.com> Co-authored-by: Jonathan Hao <jonathan@aztec-labs.com> Co-authored-by: ledwards2225 <98505400+ledwards2225@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See merge-train-readme.md.
chore: stdlib bool internal audit (#15070)
feat: improve Shplonk api (#15422)
fix(merge-train): don't queue merge if merge-train failed queue, pass on rebase logic (#15508)
chore: nuke bit array (#15522)
chore: remove template parameters (#15530)