Skip to content

chore: remove template parameters#15530

Merged
iakovenkos merged 1 commit into
merge-train/barretenbergfrom
si/remove-unnecessary-template-args
Jul 4, 2025
Merged

chore: remove template parameters#15530
iakovenkos merged 1 commit into
merge-train/barretenbergfrom
si/remove-unnecessary-template-args

Conversation

@iakovenkos

Copy link
Copy Markdown
Contributor

ECCVM- and Translator- RecursiveFlavors are only used with UltraCircuitBuilder, which allows us to decouple them and the corresponding RecursiveVerifiers from Flavor template parameter.

@iakovenkos iakovenkos marked this pull request as ready for review July 4, 2025 17:07
@iakovenkos iakovenkos requested a review from ludamad July 4, 2025 17:07
@iakovenkos iakovenkos self-assigned this Jul 4, 2025

@ludamad ludamad left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good with me - although I don't have enough insight to say how likely we would be to ever need it to be predicated on any other flavor

@iakovenkos iakovenkos changed the base branch from next to merge-train/barretenberg July 4, 2025 17:20
@iakovenkos iakovenkos enabled auto-merge (squash) July 4, 2025 17:22
@iakovenkos iakovenkos merged commit 3330e1c into merge-train/barretenberg Jul 4, 2025
8 checks passed
@iakovenkos iakovenkos deleted the si/remove-unnecessary-template-args branch July 4, 2025 17:37
github-merge-queue Bot pushed a commit that referenced this pull request Jul 4, 2025
See
[merge-train-readme.md](https://github.com/AztecProtocol/aztec-packages/blob/next/.github/workflows/merge-train-readme.md).

chore: stdlib bool internal audit  (#15070)
feat: improve Shplonk api (#15422)
fix(merge-train): don't queue merge if merge-train failed queue, pass on
rebase logic (#15508)
chore: nuke bit array (#15522)
chore: remove template parameters (#15530)

---------

Co-authored-by: AztecBot <tech@aztecprotocol.com>
Co-authored-by: sergei iakovenko <105737703+iakovenkos@users.noreply.github.com>
Co-authored-by: federicobarbacovi <171914500+federicobarbacovi@users.noreply.github.com>
Co-authored-by: Suyash Bagad <suyash@aztecprotocol.com>
Co-authored-by: Jonathan Hao <jonathan@aztec-labs.com>
Co-authored-by: ledwards2225 <98505400+ledwards2225@users.noreply.github.com>
ludamad pushed a commit that referenced this pull request Jul 9, 2025
`ECCVM-` and `Translator-` `RecursiveFlavors` are only used with
`UltraCircuitBuilder`, which allows us to decouple them and the
corresponding `RecursiveVerifiers` from `Flavor` template parameter.
github-merge-queue Bot pushed a commit that referenced this pull request Jul 9, 2025
See
[merge-train-readme.md](https://github.com/AztecProtocol/aztec-packages/blob/next/.github/workflows/merge-train-readme.md).

BEGIN_COMMIT_OVERRIDE
chore: stdlib bool internal audit  (#15070)
feat: improve Shplonk api (#15422)
fix(merge-train): don't queue merge if merge-train failed queue, pass on
rebase logic (#15508)
chore: nuke bit array (#15522)
chore: remove template parameters (#15530)
chore: no PK (#15386)
chore!: Correct public inputs propagation in the tube (#15547)
chore: use `batch_invert` in native IPA verifier (#15557)
chore: Move `stdlib::uint_plookup` to `stdlib::uint` (#15460)
chore: use const ref commitment keys (#15584)
fix: hiding circuit vk computed only once (#15589)
feat: transcript can hash objects independently (#15510)
chore: readme for benchmarking remotely (#15512)
chore: fix avm test (#15592)
chore: hash more stuff for IPA. (#15519)
chore: fix avm build in merge-train/bb (#15594)
feat!: structured public inputs via kernel io (#15383)
fix!: aggregate correct nested pairing points in the hiding circuit
(#15598)
fix: bb merge-train conflicts (#15617)
chore: Refactor shplonk verifier api (#15618)
chore!: databus consistency checks in the hiding circuit (#15599)
feat!: VK hash consistency check (#15591)
END_COMMIT_OVERRIDE

---------

Co-authored-by: AztecBot <tech@aztecprotocol.com>
Co-authored-by: sergei iakovenko <105737703+iakovenkos@users.noreply.github.com>
Co-authored-by: federicobarbacovi <171914500+federicobarbacovi@users.noreply.github.com>
Co-authored-by: Suyash Bagad <suyash@aztecprotocol.com>
Co-authored-by: Jonathan Hao <jonathan@aztec-labs.com>
Co-authored-by: ledwards2225 <98505400+ledwards2225@users.noreply.github.com>
Co-authored-by: Raju Krishnamoorthy <krishnamoorthy@gmail.com>
Co-authored-by: notnotraju <raju@aztec-labs.com>
Co-authored-by: Lucas Xia <lucasxia01@gmail.com>
Co-authored-by: Khashayar Barooti <khashayar@aztecprotocol.com>
Co-authored-by: Jean M <132435771+jeanmon@users.noreply.github.com>
Co-authored-by: Alex Gherghisan <alexghr@users.noreply.github.com>
Co-authored-by: Santiago Palladino <spalladino@users.noreply.github.com>
Co-authored-by: Santiago Palladino <santiago@aztec-labs.com>
danielntmd pushed a commit to danielntmd/aztec-packages that referenced this pull request Jul 16, 2025
See
[merge-train-readme.md](https://github.com/AztecProtocol/aztec-packages/blob/next/.github/workflows/merge-train-readme.md).

chore: stdlib bool internal audit  (AztecProtocol#15070)
feat: improve Shplonk api (AztecProtocol#15422)
fix(merge-train): don't queue merge if merge-train failed queue, pass on
rebase logic (AztecProtocol#15508)
chore: nuke bit array (AztecProtocol#15522)
chore: remove template parameters (AztecProtocol#15530)

---------

Co-authored-by: AztecBot <tech@aztecprotocol.com>
Co-authored-by: sergei iakovenko <105737703+iakovenkos@users.noreply.github.com>
Co-authored-by: federicobarbacovi <171914500+federicobarbacovi@users.noreply.github.com>
Co-authored-by: Suyash Bagad <suyash@aztecprotocol.com>
Co-authored-by: Jonathan Hao <jonathan@aztec-labs.com>
Co-authored-by: ledwards2225 <98505400+ledwards2225@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants