docs: updated code docs#15701
Merged
Merged
Conversation
benesjan
force-pushed
the
nv/rm-kernel-warnings
branch
from
abbc89a to
43df59e
Compare
benesjan
approved these changes
Jul 24, 2025
Contributor
|
I already addressed most of the changes in this PR in my other PR and after rebasing this contains only updated code docs. Adding it to merge queue since anyway that change is valuable. I am in a process of fixing all the warnings in this PR. Fixing the warnings became high priority because new Noir will disallow accessing of private fields. |
federicobarbacovi
added a commit
that referenced
this pull request
Jul 24, 2025
commit 3dbca03 Author: federicobarbacovi <171914500+federicobarbacovi@users.noreply.github.com> Date: Thu Jul 24 13:24:16 2025 +0000 Typos commit 6a8a523 Author: federicobarbacovi <171914500+federicobarbacovi@users.noreply.github.com> Date: Thu Jul 24 13:11:25 2025 +0000 Fixes commit b9e62d6 Author: federicobarbacovi <171914500+federicobarbacovi@users.noreply.github.com> Date: Thu Jul 24 12:15:59 2025 +0000 Update remaining files commit 37088cd Author: federicobarbacovi <171914500+federicobarbacovi@users.noreply.github.com> Date: Thu Jul 24 11:47:45 2025 +0000 Update Goblin boomerang test commit 39ac8c2 Author: federicobarbacovi <171914500+federicobarbacovi@users.noreply.github.com> Date: Thu Jul 24 11:46:02 2025 +0000 Update goblin commit 888fc82 Author: federicobarbacovi <171914500+federicobarbacovi@users.noreply.github.com> Date: Thu Jul 24 11:26:40 2025 +0000 Update merge verifier api commit 4fb769b Merge: eaf251e f70e99d Author: AztecBot <tech@aztecprotocol.com> Date: Thu Jul 24 09:38:03 2025 +0000 Merge branch 'next' into merge-train/barretenberg commit f70e99d Author: Nicolás Venturo <nicolas.venturo@gmail.com> Date: Thu Jul 24 05:55:55 2025 -0300 docs: updated code docs (#15701) With `Empty` being a supertrait of `Eq`, `Empty + Eq` becomes meaningless - this was emitting warnings. @LeilaWang what do you think about setting up a CI job that checks the protocol circuit crates emit no warnings? That's what we use in aztec-nr and it's been working wonderfully. tldr you need to run `nargo check --deny-warnings`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
Emptybeing a supertrait ofEq,Empty + Eqbecomes meaningless - this was emitting warnings.@LeilaWang what do you think about setting up a CI job that checks the protocol circuit crates emit no warnings? That's what we use in aztec-nr and it's been working wonderfully. tldr you need to run
nargo check --deny-warnings.