chore: fixing noir warnings#15856
Merged
Merged
Conversation
benesjan
force-pushed
the
07-21-chore_fixing_noir_warnings
branch
from
f03d6c1 to
fd9b776
Compare
benesjan
force-pushed
the
07-21-chore_fixing_noir_warnings
branch
from
fd9b776 to
ba0d164
Compare
benesjan
force-pushed
the
07-21-chore_fixing_noir_warnings
branch
from
92da17d to
5e9d24e
Compare
benesjan
commented
Jul 24, 2025
|
|
||
| fn next_counter(&mut self) -> u32 { | ||
| // This function got exposed publicly to be able to access it in ContractClassRegistry. | ||
| // TODO: Should we introduce an abstraction such that accessing this externally is not needed? |
Contributor
Author
There was a problem hiding this comment.
I think unblocking the next noir sync is more important than this so just lazily added here and below a TODO
Contributor
There was a problem hiding this comment.
The change is trivial, we just need a method for pushing contract class log hashes
benesjan
commented
Jul 24, 2025
| @@ -1,4 +1,4 @@ | |||
| mod balance_utils; | |||
| pub mod balance_utils; | |||
Contributor
Author
There was a problem hiding this comment.
Having this in the value note in the first place is strange. Probably worthy of moving in a separate PR
benesjan
commented
Jul 24, 2025
benesjan
commented
Jul 24, 2025
benesjan
commented
Jul 24, 2025
benesjan
commented
Jul 24, 2025
| aztec = { path = "../../../../aztec-nr/aztec" } | ||
| keccak256 = { tag = "v0.1.0", git = "https://github.com/noir-lang/keccak256" } | ||
| sha256 = { tag = "v0.1.2", git = "https://github.com/noir-lang/sha256" } | ||
| poseidon = { tag= "v0.1.1", git = "https://github.com/noir-lang/poseidon" } |
Contributor
Author
There was a problem hiding this comment.
The poseidon function are no longer exposed on noir::std so I am exposing this here.
dbanks12
reviewed
Jul 24, 2025
dbanks12
left a comment
dbanks12
left a comment
Contributor
There was a problem hiding this comment.
public context looks good
nventuro
reviewed
Jul 24, 2025
|
|
||
| fn next_counter(&mut self) -> u32 { | ||
| // This function got exposed publicly to be able to access it in ContractClassRegistry. | ||
| // TODO: Should we introduce an abstraction such that accessing this externally is not needed? |
Contributor
There was a problem hiding this comment.
The change is trivial, we just need a method for pushing contract class log hashes
| unconstrained fn call( | ||
|
|
||
| // This function is temporarily exposed publicly to be able to test it in AVMTest contract. | ||
| // TODO: Refactor tests to keep this implementation detail private within the crate. |
Contributor
There was a problem hiding this comment.
Are you planning on doing this?
Contributor
Author
There was a problem hiding this comment.
Created an issue and will try to figure this out next week.
…src/cards.nr Co-authored-by: Nicolás Venturo <nicolas.venturo@gmail.com>
…e` method instead of direct field assignment for commitment.
nventuro
approved these changes
Jul 25, 2025
nventuro
added a commit
that referenced
this pull request
Jul 25, 2025
Fixing the vast majority of compiler warnings in `noir-projects`. Tackling this now as incoming Noir release will disallow accessing of private fields and private functionality. These warnings are remaining: <img width="1128" height="523" alt="image" src="https://github.com/user-attachments/assets/a9372a2b-ce93-41f3-9a4b-ffa96b60ba5f" /> The first one is impractical to fix, the 2nd, 3rd and 4th I am not sure how to fix and the last one I plan on making the AVM team fix. --------- Co-authored-by: Nicolás Venturo <nicolas.venturo@gmail.com>
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Jul 30, 2025
Fixes #15980 In [this PR](#15856) I incorrectly exposed a couple of functions. In this PR I un-expose both. The `next_counter` got tackled by me moving the `emit_contract_class_log` to private context which is where it actually should be. For the `call` function I decided to just disable the test funcitons in which it was used. It's up to the AVM team to re-enable those tests. Created [an issue](#16099) for that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing the vast majority of compiler warnings in
noir-projects.Tackling this now as incoming Noir release will disallow accessing of private fields and private functionality.
These warnings are remaining:
The first one is impractical to fix, the 2nd, 3rd and 4th I am not sure how to fix and the last one I plan on making the AVM team fix.