fix: disable asserts in wasm builds#15922
Merged
johnathan79717 merged 1 commit intoJul 23, 2025
Merged
Conversation
ludamad
approved these changes
Jul 23, 2025
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Jul 24, 2025
See [merge-train-readme.md](https://github.com/AztecProtocol/aztec-packages/blob/next/.github/workflows/merge-train-readme.md). BEGIN_COMMIT_OVERRIDE chore: Update `UltraVerifier` api to return public inputs in the case of a MegaFlavor (#15868) chore: byte array audit (#15723) feat: update vk in test_civc_standalone_vks_havent_changed.sh via `bb check --update_inputs` (#15840) fix: disable asserts in wasm builds (#15922) chore: simplifying Honk VK length constants (#15895) chore!: update Aztec structured trace sizes (#15929) feat: hiding circuit in noir (#15704) END_COMMIT_OVERRIDE --------- Co-authored-by: AztecBot <tech@aztecprotocol.com> Co-authored-by: federicobarbacovi <171914500+federicobarbacovi@users.noreply.github.com> Co-authored-by: ledwards2225 <98505400+ledwards2225@users.noreply.github.com> Co-authored-by: sergei iakovenko <105737703+iakovenkos@users.noreply.github.com> Co-authored-by: Jonathan Hao <jonathan@aztec-labs.com> Co-authored-by: Khashayar Barooti <khashayar@aztecprotocol.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#15671 regressed wasm performance by 5.5%, so this PR disables them in wasm.
Ran on the benchmark machine via
scripts/benchmark_remote.sh client_ivc_bench '/bin/time -v ../scripts/wasmtime.sh client_ivc_bench --benchmark_filter=ClientIVCBench/Full/6' wasm-threads build-wasm-threadsThis branch:
Merge train: