Skip to content

fix: disable asserts in wasm builds #15922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
johnathan79717 merged 1 commit into from
Jul 23, 2025
Merged

fix: disable asserts in wasm builds #15922

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions barretenberg/cpp/src/barretenberg/common/assert.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,16 @@
#include <sstream>

// NOLINTBEGIN
#if NDEBUG
// Compiler should optimize this out in release builds, without triggering unused-variable warnings.
#define DONT_EVALUATE(expression) \
{ \
true ? static_cast<void>(0) : static_cast<void>((expression)); \
}

#if NDEBUG

// All assertion macros accept an optional message but do nothing in release.
#define ASSERT_DEBUG_ONLY(expression, ...) DONT_EVALUATE((expression))
#define ASSERT_DEBUG(expression, ...) DONT_EVALUATE((expression))

#else
#include "barretenberg/common/log.hpp"
Expand All @@ -25,6 +26,16 @@
#define ASSERT_DEBUG(expression, ...) ASSERT(expression, __VA_ARGS__)
#endif // NDEBUG

#ifdef __wasm__
#define ASSERT_IN_CONSTEXPR(expression, ...) DONT_EVALUATE((expression))
#define ASSERT(expression, ...) DONT_EVALUATE((expression))

#define BB_ASSERT_EQ(actual, expected, ...) DONT_EVALUATE((actual) == (expected))
#define BB_ASSERT_GT(left, right, ...) DONT_EVALUATE((left) > (right))
#define BB_ASSERT_GTE(left, right, ...) DONT_EVALUATE((left) >= (right))
#define BB_ASSERT_LT(left, right, ...) DONT_EVALUATE((left) < (right))
#define BB_ASSERT_LTE(left, right, ...) DONT_EVALUATE((left) <= (right))
#else
#define ASSERT_IN_CONSTEXPR(expression, ...) \
do { \
if (!(expression)) { \
Expand Down Expand Up @@ -113,6 +124,7 @@
throw_or_abort(oss.str()); \
} \
} while (0)
#endif // __wasm__

// These are used in tests.
#ifdef BB_NO_EXCEPTIONS
Expand All @@ -121,6 +133,5 @@
#else
#define ASSERT_THROW_OR_ABORT(statement, matcher) ASSERT_THROW(statement, std::runtime_error)
#define EXPECT_THROW_OR_ABORT(statement, matcher) EXPECT_THROW(statement, std::runtime_error)
#endif

#endif // BB_NO_EXCEPTIONS
// NOLINTEND
Loading