chore: compute beta products for max log dyadic size instead of 21#16772
Merged
Conversation
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Sep 4, 2025
BEGIN_COMMIT_OVERRIDE chore: compute beta products for max log dyadic size instead of 21 (#16772) chore: bool_t from witness index functionality (#16688) chore: audit the set relation of the ECCVM (#16706) chore: update readme in the eccvm to include description of multiset and lookups (#16765) END_COMMIT_OVERRIDE
Maddiaa0
pushed a commit
that referenced
this pull request
Sep 4, 2025
mralj
pushed a commit
that referenced
this pull request
Oct 13, 2025
ludamad
pushed a commit
that referenced
this pull request
Dec 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From running
BB_BENCH=1 ./build/bin/client_ivc_bench --benchmark_filter='.*Full/5.*', we can see that thecompute_combineronly takes up 53.3% of the time ofcombiner_quotient_round.After some investigation, about 40% of the time was spent on
compute_beta_productsto construct gate separators. Its size was a constant 2**21 but we only use it up to the dyadic size of the circuit. This PR passes the max dyadic size instead.This change saved about 500ms from
combiner_quotient_roundin theFull/5benchmark.