feat: merge-train/barretenberg#16775
Merged
Merged
Conversation
Several `bool_t` improvements: * added a `from_witness_index_unsafe` constructor that implicitly appeared in #16663 * turned `witness_index` and other class members private * added a more efficient constructor that takes a `witness_t` and uses range constraints instead of `bool_gate`. see [related issue](AztecProtocol/barretenberg#1533) + the tests As a byproduct: * some simplifications in `compute_naf` method * using `get_normalized_witness_index` on `bool_t` outside of the friend `field_t` and `biggroup` classes * slightly improved `used_witnesses` handling in a couple of places. The vks and the number of gates have changed due to a tiny opt related to re-using a couple of `bool_t` results in `+` and `-` in `biggroup`
Only added documentation. I did not spend time trying to optimize the degrees. --------- Co-authored-by: notnotraju <raju@aztec-labs.com>
…and lookups (#16765) updated eccvm docs to sketch multiset matching and lookups. --------- Co-authored-by: notnotraju <raju@aztec-labs.com>
Collaborator
Author
|
🤖 Auto-merge enabled after 4 hours of inactivity. This PR will be merged automatically once all checks pass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BEGIN_COMMIT_OVERRIDE
chore: compute beta products for max log dyadic size instead of 21 (#16772)
chore: bool_t from witness index functionality (#16688)
chore: audit the set relation of the ECCVM (#16706)
chore: update readme in the eccvm to include description of multiset and lookups (#16765)
END_COMMIT_OVERRIDE