refactor: fixing offchain/onchain naming#16942
Merged
Merged
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
benesjan
requested review from
LHerskind,
LeilaWang,
Maddiaa0 and
just-mitch
as code owners
benesjan
commented
Sep 11, 2025
| * @notice Get the proposer for the slot at a specific timestamp | ||
| * | ||
| * @dev This function is very useful for off-chain usage, as it easily allow a client to | ||
| * @dev This function is very useful for offchain usage, as it easily allow a client to |
Contributor
Author
There was a problem hiding this comment.
@LHerskind are you fine with me merging these changes to the contracts given that they were audited? Can revert this if you prefer.
Contributor
Author
There was a problem hiding this comment.
Got a DM that Lasse is fine with this.
nventuro
reviewed
Sep 11, 2025
nventuro
left a comment
nventuro
left a comment
Contributor
There was a problem hiding this comment.
Given there's so many instances of these, maybe consider adding cspell rules to prevent regressions?
benesjan
force-pushed
the
09-11-refactor_fixing_offchain_onchain_naming
branch
from
abef340 to
debd73b
Compare
Contributor
Author
benesjan
force-pushed
the
09-11-refactor_fixing_offchain_onchain_naming
branch
from
debd73b to
d76975f
Compare
iAmMichaelConnor
approved these changes
Sep 11, 2025
AztecBot
force-pushed
the
09-11-refactor_fixing_offchain_onchain_naming
branch
from
d76975f to
c46944c
Compare
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
benesjan
force-pushed
the
09-11-refactor_fixing_offchain_onchain_naming
branch
from
c46944c to
d2c9374
Compare
AztecBot
force-pushed
the
09-11-refactor_fixing_offchain_onchain_naming
branch
from
d2c9374 to
c84c8f7
Compare
We were inconsistent in our naming: For the meaning of `offchain` we used the following: - off-chain - offchain - out-of-band And for `onchain` we used - on-chain - onchain Decided to just use `offchain` and `onchain` consistently. I think out-of-band term was genuinely harmful when it comes to external devs understanding what's going on.
benesjan
force-pushed
the
09-11-refactor_fixing_offchain_onchain_naming
branch
from
c84c8f7 to
b208c8e
Compare
ludamad
pushed a commit
that referenced
this pull request
Dec 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were inconsistent in our naming:
For the meaning of
offchainwe used the following:And for
onchainwe usedDecided to just use
offchainandonchainconsistently. I think out-of-band term was genuinely harmful when it comes to external devs understanding what's going on.