refactor: another message related naming fixes#16946
Merged
benesjan merged 1 commit intoSep 23, 2025
Merged
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
benesjan
commented
Sep 11, 2025
| recipient: AztecAddress, | ||
| ) { | ||
| // do_process_log expects a standard aztec-nr encoded note, which has the following shape: | ||
| // do_process_message expects a standard aztec-nr encoded note, which has the following shape: |
Contributor
Author
There was a problem hiding this comment.
do_process_log was renamed to do_process_message a while ago.
benesjan
commented
Sep 11, 2025
| }, | ||
| encryption::log_encryption::LogEncryption, | ||
| encryption::message_encryption::MessageEncryption, | ||
| logs::arithmetic_generics_utils::{ |
Contributor
Author
There was a problem hiding this comment.
The noir-projects/aztec-nr/aztec/src/messages/logs directory should be renamed but that is for another PR (would make this one un-reviewable as then the diff would be broken).
benesjan
commented
Sep 11, 2025
| @@ -33,57 +33,57 @@ fn get_arr_of_size__ciphertext<let FullPt: u32, let PtAesPadding: u32>( | |||
|
|
|||
| // Ok, so we have the following bytes: | |||
Contributor
Author
There was a problem hiding this comment.
Big diff in this file but it's all just renamings
benesjan
commented
Sep 11, 2025
|
|
||
| // Ok, so we have the following bytes: | ||
| // eph_pk_sign, header_ciphertext, ciphertext: | ||
| // Let lbwop = 1 + HEADER_CIPHERTEXT_SIZE_IN_BYTES + |ct| // aka log bytes without padding |
Contributor
Author
There was a problem hiding this comment.
"log bytes without padding" --> "message bytes without padding"
benesjan
force-pushed
the
09-11-refactor_another_message_related_naming_fixes
branch
from
f47e508 to
73884f0
Compare
benesjan
force-pushed
the
09-11-refactor_fixing_offchain_onchain_naming
branch
from
abef340 to
debd73b
Compare
benesjan
force-pushed
the
09-11-refactor_another_message_related_naming_fixes
branch
from
73884f0 to
041d921
Compare
benesjan
force-pushed
the
09-11-refactor_fixing_offchain_onchain_naming
branch
from
debd73b to
d76975f
Compare
benesjan
force-pushed
the
09-11-refactor_another_message_related_naming_fixes
branch
from
041d921 to
d66397e
Compare
AztecBot
force-pushed
the
09-11-refactor_fixing_offchain_onchain_naming
branch
from
d76975f to
c46944c
Compare
AztecBot
requested review from
LHerskind,
LeilaWang,
Maddiaa0 and
just-mitch
as code owners
benesjan
changed the base branch from
09-11-refactor_fixing_offchain_onchain_naming
to
graphite-base/16946
benesjan
force-pushed
the
09-11-refactor_another_message_related_naming_fixes
branch
from
d66397e to
e930b81
Compare
benesjan
force-pushed
the
graphite-base/16946
branch
from
c46944c to
0ca5388
Compare
benesjan
force-pushed
the
09-11-refactor_another_message_related_naming_fixes
branch
from
e930b81 to
d90b28b
Compare
AztecBot
force-pushed
the
09-11-refactor_another_message_related_naming_fixes
branch
from
d90b28b to
b042d34
Compare
Fixes #16885 As promised in [here](#16882 (comment)) in this PR I rename `LogEncryption` trait as `MessageEncryption` and I drop "_log" from it's method names. Didn't replace it with "_message" as it seemed unncessary. I also do some related minor renamings.
AztecBot
force-pushed
the
09-11-refactor_another_message_related_naming_fixes
branch
from
b042d34 to
c4b4d5e
Compare
auto-merge was automatically disabled
September 23, 2025 16:45
Pull Request is not mergeable
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
benesjan
deleted the
09-11-refactor_another_message_related_naming_fixes
branch
ludamad
pushed a commit
that referenced
this pull request
Dec 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16885
As promised in here in this PR I rename
LogEncryptiontrait asMessageEncryptionand I drop "_log" from it's method names. Didn't replace it with "_message" as it seemed unncessary. I also do some related minor renamings.