feat(docs): add tabs for deploying contract with cli and aztec.js#1703
Merged
Conversation
Maddiaa0
changed the title
LHerskind
reviewed
Aug 21, 2023
benesjan
requested changes
Aug 22, 2023
benesjan
left a comment
benesjan
left a comment
Contributor
There was a problem hiding this comment.
Looks good. Just added a few suggestions. Will approve once you address them.
benesjan
approved these changes
Aug 22, 2023
LHerskind
requested changes
Aug 22, 2023
| </TabItem> | ||
| <TabItem value="js" label="Aztec.js"> | ||
|
|
||
| Pre-requisite - Generate type-safe typescript classes for your contract when compiling: |
Contributor
There was a problem hiding this comment.
Is there a way to do this from aztec js as well? Ideally, want to support doing it fully programatically with aztec js and not having to touch the cli for some tests etc.
Contributor
There was a problem hiding this comment.
| <TabItem value="js" label="Aztec.js"> | ||
|
|
||
| ```ts | ||
| contract = await PrivateTokenContract.deploy(wallet, initialBalance, owner).send({ contractAddressSalt: Fr.fromString("0x123") }).deployed(); |
Contributor
There was a problem hiding this comment.
More api wise, but why are we not just calling it a salt?
| <TabItem value="js" label="Aztec.js"> | ||
|
|
||
| ```ts | ||
| contract = await PrivateTokenContract.deploy(wallet, initialBalance, owner).send({ contractAddressSalt: Fr.fromString("0x123") }).deployed(); |
Contributor
There was a problem hiding this comment.
Suggested change
| contract = await PrivateTokenContract.deploy(wallet, initialBalance, owner).send({ contractAddressSalt: Fr.fromString("0x123") }).deployed(); | |
| const contract = await PrivateTokenContract.deploy(wallet, initialBalance, owner).send({ contractAddressSalt: Fr.fromString("0x123") }).deployed(); |
rahul-kothari
force-pushed
the
rk/contract_docs
branch
from
2ec66ea to
e126692
Compare
Co-authored-by: Jan Beneš <janbenes1234@gmail.com>
rahul-kothari
force-pushed
the
rk/contract_docs
branch
from
e126692 to
4a08461
Compare
rahul-kothari
force-pushed
the
rk/contract_docs
branch
from
4a08461 to
174757d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1608