Skip to content

remove manual cp from Dockerfiles#184

Closed
spypsy wants to merge 4 commits into
masterfrom
sp/ci-wasm
Closed

remove manual cp from Dockerfiles#184
spypsy wants to merge 4 commits into
masterfrom
sp/ci-wasm

Conversation

@spypsy

@spypsy spypsy commented Apr 5, 2023

Copy link
Copy Markdown
Member

Description

  • add build:link as part of building bb.js and circuits.js so no manual cp step is needed in Dockerfiles that depend on them

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • I have linked this pull request to the issue(s) that it resolves.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • The branch has been merged or rebased against the head of its merge target.
  • I'm happy for the PR to be merged at the reviewer's next convenience.

@spalladino

Copy link
Copy Markdown
Contributor

@spypsy I think we can close this after #229, right?

@ludamad ludamad closed this Apr 14, 2023
@ludamad ludamad deleted the sp/ci-wasm branch July 14, 2023 23:02
PhilWindle added a commit that referenced this pull request May 29, 2026
- Replace stale `AZTEC_LAG_IN_EPOCHS` in `tps-scenario.env` with
`AZTEC_LAG_IN_EPOCHS_FOR_VALIDATOR_SET` and
`AZTEC_LAG_IN_EPOCHS_FOR_RANDAO` (value 1 each).
- Fixes immediate failure in nightly Spartan `wait-bench-l2-block` ([run
#184](https://github.com/AztecProtocol/aztec-packages/actions/runs/26627597396/job/78472605259)).

Co-authored-by: PhilWindle <60546371+PhilWindle@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants