Move wasms to shared resources folder and clean up dockerfiles#229
Merged
Conversation
spypsy
approved these changes
Apr 11, 2023
spypsy
left a comment
Member
There was a problem hiding this comment.
think the resources idea is nice, no more having to worry about copying to dest, either in docker or during yarn build.
Not a big fan of copying everything in the Dockerfiles but if doesn't actually affect performance I don't see a reason to not do it
Contributor
Author
We can always roll it back, as long as we automate the listing of deps to copy in the dockerfile! |
6 tasks
ludamad
pushed a commit
that referenced
this pull request
Apr 14, 2023
* chore(specs): remove * chore(specs): remove * revert bb change --------- Co-authored-by: cheethas <urmasurda@gmail.com>
ludamad
pushed a commit
that referenced
this pull request
Apr 17, 2023
* chore(specs): remove * chore(specs): remove * revert bb change --------- Co-authored-by: cheethas <urmasurda@gmail.com>
ludamad
pushed a commit
that referenced
this pull request
Apr 17, 2023
* chore(specs): remove * chore(specs): remove * revert bb change --------- Co-authored-by: cheethas <urmasurda@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
src(in both bb and circuits) to aresourcesfolder, to be accessed from bothsrcanddist. This removes the need for a manual post-build step to copy or symlink the wasm, which was required also when building a package that depended on these. Cleans up dockerfiles to remove these build steps. Fixes Relocate wasm artifact within ts packages #206.