Skip to content

chore(avm): use ContractDeploymentData.fromPlainObject#18855

Merged
fcarreiro merged 1 commit into
merge-train/avmfrom
fc/fromplainobject
Dec 8, 2025
Merged

chore(avm): use ContractDeploymentData.fromPlainObject#18855
fcarreiro merged 1 commit into
merge-train/avmfrom
fc/fromplainobject

Conversation

@fcarreiro

@fcarreiro fcarreiro commented Dec 8, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

We have a better way to do this, so use it.

@fcarreiro Graphite App

fcarreiro commented Dec 8, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@fcarreiro fcarreiro mentioned this pull request Dec 8, 2025
Merged
@fcarreiro fcarreiro requested a review from dbanks12 December 8, 2025 17:33
@fcarreiro fcarreiro force-pushed the fc/fromplainobject branch 2 times, most recently from 505c194 to 9550e38 Compare December 8, 2025 18:11
@fcarreiro fcarreiro added the ci-full Run all master checks. label Dec 8, 2025 — with Graphite App
@fcarreiro fcarreiro marked this pull request as ready for review December 8, 2025 19:14
@AztecBot

AztecBot commented Dec 8, 2025

Copy link
Copy Markdown
Collaborator

Flakey Tests

🤖 says: This CI run detected 1 tests that failed, but were tolerated due to a .test_patterns.yml entry.

\033FLAKED\033 (\0338;;http://ci.aztec-labs.com/9833ceefcf7bede2�9833ceefcf7bede28;;�\033): yarn-project/scripts/run_test.sh ethereum/src/l1_tx_utils/l1_tx_utils.test.ts (66s) (code: 1) group:e2e-p2p-epoch-flakes (\033fcarreiro\033: chore(avm): use ContractDeploymentData.fromPlainObject)

@fcarreiro Graphite App

fcarreiro commented Dec 8, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Merge activity

  • Dec 8, 8:00 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Dec 8, 8:02 PM UTC: Graphite rebased this pull request as part of a merge.
  • Dec 8, 8:03 PM UTC: @fcarreiro merged this pull request with Graphite.

@fcarreiro fcarreiro changed the base branch from fc/dont-hash to graphite-base/18855 December 8, 2025 20:00
@fcarreiro fcarreiro changed the base branch from graphite-base/18855 to merge-train/avm December 8, 2025 20:01
@fcarreiro fcarreiro removed the ci-full Run all master checks. label Dec 8, 2025
@fcarreiro fcarreiro merged commit c24fe38 into merge-train/avm Dec 8, 2025
7 of 8 checks passed
@fcarreiro fcarreiro deleted the fc/fromplainobject branch December 8, 2025 20:03
@AztecBot AztecBot mentioned this pull request Dec 8, 2025
Merged
github-merge-queue Bot pushed a commit that referenced this pull request Dec 8, 2025
@fcarreiro
feat: merge-train/avm (#18867)
998ab54 
BEGIN_COMMIT_OVERRIDE
test(avm): e2e tests can optionally dump avm circuit inputs to files
(#18747)
feat(avm): don't hash bytecode in fast simulation (#18853)
chore(avm): use ContractDeploymentData.fromPlainObject (#18855)
chore(avm): earlier bytecode deduplication
END_COMMIT_OVERRIDE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dbanks12 dbanks12 dbanks12 approved these changes

@sirasistant sirasistant Awaiting requested review from sirasistant

@jeanmon jeanmon Awaiting requested review from jeanmon jeanmon is a code owner

@IlyasRidhuan IlyasRidhuan Awaiting requested review from IlyasRidhuan IlyasRidhuan is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fcarreiro @AztecBot @dbanks12