test(avm): e2e tests can optionally dump avm circuit inputs to files#18747
Merged
dbanks12 merged 8 commits intoDec 8, 2025
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
dbanks12
force-pushed
the
12-03-test_avm_e2e_tests_can_optionally_dump_avm_circuit_inputs_to_files
branch
from
b206756 to
ad70f5c
Compare
dbanks12
requested review from
charlielye,
fcarreiro and
sirasistant
as code owners
dbanks12
force-pushed
the
12-03-test_avm_e2e_tests_can_optionally_dump_avm_circuit_inputs_to_files
branch
from
ad70f5c to
479051b
Compare
dbanks12
force-pushed
the
12-03-test_avm_e2e_tests_can_optionally_dump_avm_circuit_inputs_to_files
branch
9 times, most recently
from
4197c52 to
985d629
Compare
dbanks12
requested review from
ludamad
and removed request for
charlielye,
fcarreiro and
sirasistant
ludamad
reviewed
Dec 6, 2025
ludamad
reviewed
Dec 6, 2025
ludamad
reviewed
Dec 6, 2025
dbanks12
force-pushed
the
12-03-test_avm_e2e_tests_can_optionally_dump_avm_circuit_inputs_to_files
branch
2 times, most recently
from
aa1d3fe to
b9e87bc
Compare
dbanks12
commented
Dec 8, 2025
dbanks12
force-pushed
the
12-03-test_avm_e2e_tests_can_optionally_dump_avm_circuit_inputs_to_files
branch
2 times, most recently
from
2f6cfcd to
16deebe
Compare
ludamad
reviewed
Dec 8, 2025
| run: | | ||
| # Use tree hash for tarball name - consistent across all environments | ||
| # Same content = same tree hash, even across different commits | ||
| TREE_HASH=$(git rev-parse HEAD^{tree}) |
Collaborator
There was a problem hiding this comment.
the commit hash was probably fine but this works
ludamad
reviewed
Dec 8, 2025
| aws s3 cp "s3://aztec-ci-artifacts/build-cache/$TARBALL_NAME" "./$TARBALL_NAME" | ||
|
|
||
| - name: Upload AVM inputs artifact | ||
| uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 |
dbanks12
force-pushed
the
12-03-test_avm_e2e_tests_can_optionally_dump_avm_circuit_inputs_to_files
branch
from
16deebe to
ce61c4b
Compare
ludamad
approved these changes
Dec 8, 2025
Collaborator
|
LGTM |
dbanks12
force-pushed
the
12-03-test_avm_e2e_tests_can_optionally_dump_avm_circuit_inputs_to_files
branch
from
ce61c4b to
eb7ebe5
Compare
dbanks12
deleted the
12-03-test_avm_e2e_tests_can_optionally_dump_avm_circuit_inputs_to_files
branch
Merged
This was referenced May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Engineering Design Document
To gain confidence in the AVM circuit (its completeness in particular), we would like to prove all end-to-end tests. Changing all of those tests to run provers is a huge task and would lead to very slow tests. Instead, we can take a much simpler approach of optionally dumping all AvmCircuitInputs (basically the proving requests for the AVM) to a tarball that gets cached. This can be wrapped in a CI job that runs on
nextcommits, and paired with another job that iterates over all such AvmCircuitInputs and proves (or just check-circuits) them.This will help us gain confidence in the AVM circuit, add a layer of regression testing, and provide more transactions to feed our fuzzing corpus.
Proposed solution: Add a
DumpingCppPublicTxSimulatorthat extends the base simulator and writes circuit inputs to disk after each simulation. Control via an environment variableDUMP_AVM_INPUTS_TO_DIR. Run nightly in CI, package results, and upload to S3 cache. Run another nightly CI job to download from cache and prove (or probably just check-circuit) all collected inputs.