Skip to content

fix: Fix script for testing vks haven't changed #20852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
federicobarbacovi merged 5 commits into from
Feb 25, 2026
Merged

fix: Fix script for testing vks haven't changed #20852

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
70b4d86
Return code correctly extracted
federicobarbacovi Feb 25, 2026
59a5514
Standardise: proof -> prove
federicobarbacovi Feb 25, 2026
e8fc604
Retry CI
federicobarbacovi Feb 25, 2026
8ac0547
Move script path calculation
federicobarbacovi Feb 25, 2026
c106268
Try again
federicobarbacovi Feb 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions barretenberg/cpp/scripts/test_chonk_standalone_vks_havent_changed.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,10 @@ source $(git rev-parse --show-toplevel)/ci3/source

# export bb as it is needed when using exported functions
export bb="$root/barretenberg/cpp/$(./native-preset-build-dir)/bin/bb"
cd ..

# script path to auto update short hash
script_path="$root/barretenberg/cpp/scripts/test_chonk_standalone_vks_havent_changed.sh"


# NOTE: We pin the captured IVC inputs to a known master commit, exploiting that there won't be frequent changes.
# This allows us to compare the generated VKs here with ones we compute freshly, detecting breaking protocol changes.
Expand All @@ -16,8 +19,6 @@ cd ..
pinned_short_hash="189f0026"
pinned_chonk_inputs_url="https://aztec-ci-artifacts.s3.us-east-2.amazonaws.com/protocol/bb-chonk-inputs-${pinned_short_hash}.tar.gz"

script_path="$(cd "$(dirname "${BASH_SOURCE[0]}")/scripts" && pwd)/$(basename "${BASH_SOURCE[0]}")"

function update_pinned_hash_in_script {
local new_hash=$1
echo "Updating pinned_short_hash in script to: $new_hash"
Expand Down Expand Up @@ -80,12 +81,12 @@ export -f check_circuit_vks
function prove_and_verify_inputs {
set -eu
local flow_folder="$inputs_dir/$1"
local proof_exit_code=0
local prove_exit_code=0

echo "Running proof test for $1..."
$bb prove --scheme chonk --ivc_inputs_path "$flow_folder/ivc-inputs.msgpack" > /dev/null 2>&1 || prove_exit_code=$?

if [[ $proof_exit_code -ne 0 ]]; then
if [[ $prove_exit_code -ne 0 ]]; then
echo "Proof test failed for flow $1. Please re-run the script with flag --update_inputs."

cp "$flow_folder/ivc-inputs.msgpack" "$root/yarn-project/end-to-end/example-app-ivc-inputs-out/$1/ivc-inputs.msgpack"
Expand Down Expand Up @@ -139,7 +140,7 @@ if [[ "${1:-}" == "-h" || "${1:-}" == "--help" ]]; then
EOF
exit 0
elif [[ "${1:-}" == "--update_inputs" ]]; then
export inputs_dir="../../yarn-project/end-to-end/example-app-ivc-inputs-out"
export inputs_dir="$root/yarn-project/end-to-end/example-app-ivc-inputs-out"

# For easily rerunning the inputs generation
set -eu
Expand Down
Loading