fix: Fix script for testing vks haven't changed#20852
Merged
federicobarbacovi merged 5 commits intoFeb 25, 2026
Merged
Conversation
ludamad
approved these changes
Feb 25, 2026
federicobarbacovi
merged commit 57adc51
into
merge-train/barretenberg
19 of 20 checks passed
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Feb 27, 2026
BEGIN_COMMIT_OVERRIDE chore: builders audit response 0 (#20792) feat: early circuit block deallocation after trace populate (#20776) fix: Fix script for testing vks haven't changed (#20852) fix: move debug_incoming_circuit before block deallocation in Chonk::accumulate (#20876) refactor: deduplicate debug_incoming_circuit in Chonk::accumulate (#20870) fix: denoise causing mysterious error 141 (#20871) feat: make clang20 preset use zig with glibc 2.35 (#20897) chore: remove final instances of unneeded +1 in SRS construction (#20912) chore: avoid use of size_t in bbapi to be safe (#20916) chore: Claudebox remedy example (#20922) END_COMMIT_OVERRIDE
johnathan79717
pushed a commit
that referenced
this pull request
Mar 4, 2026
When verifying the inputs can be proven, we were extracting the exit code of `bb prove` to a variable that was never used. This meant that the script would always pass, even though the inputs were wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When verifying the inputs can be proven, we were extracting the exit code of
bb proveto a variable that was never used. This meant that the script would always pass, even though the inputs were wrong.