Skip to content

fix: denoise causing mysterious error 141 #20871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ludamad merged 16 commits into from
Feb 26, 2026
Merged

fix: denoise causing mysterious error 141 #20871

Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
0957567
dbg
ludamad Feb 25, 2026
e7c6775
-
ludamad Feb 25, 2026
6a83bd1
fix(ci3): emit sentinel to prevent SIGPIPE when all tests are cached
ludamad Feb 25, 2026
b63677c
fix(ci3): handle SIGPIPE in bb test when all tests are cached
ludamad Feb 25, 2026
872f43c
fix(ci3): buffer test_cmds to file to avoid SIGPIPE when all cached
ludamad Feb 25, 2026
1588f35
dbg: add set -x to parallelize to trace why it exits early
ludamad Feb 25, 2026
97f763a
dbg: add set -x to filter_cached_test_cmd to find early exit cause
ludamad Feb 25, 2026
5f8b444
dbg: capture parallel --pipe exit code in filter_cached_test_cmd
ludamad Feb 25, 2026
b889ee9
probe
ludamad Feb 26, 2026
89b38db
probe
ludamad Feb 26, 2026
526643e
probe
ludamad Feb 26, 2026
8224dff
probe
ludamad Feb 26, 2026
6a0edcd
probe
ludamad Feb 26, 2026
6d8f418
probe
ludamad Feb 26, 2026
2dca16e
fix: denoise stdin lost for background job - pass stdin explicitly to…
ludamad Feb 26, 2026
eb1cb7a
Try just a revert
ludamad Feb 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ci3/denoise
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ tail --sleep-interval=0.2 -n +1 -f "$outfile" > >(
tail_pid=$!

# Execute the command in background.
PARENT_LOG_ID=$key bash -c "$cmd" > >(redact > $outfile) 2>&1 &
PARENT_LOG_ID=$key bash -c "$cmd" 2>&1 | redact > $outfile &
job_pid=$!

# Wait for the job to finish and get its exit status.
Expand Down
Loading