fix: denoise causing mysterious error 141#20871
Merged
Merged
Conversation
When all tests are filtered by filter_cached_test_cmd, parallelize receives empty stdin causing GNU parallel to exit and the upstream pipeline to receive SIGPIPE (exit 141). Emit a trailing empty line as a sentinel; run_test_cmd already handles empty commands with an early exit 0, and parallelize already excludes them from the count. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
test_cmds_native runs each test binary with --gtest_list_tests to enumerate tests, which takes real time across 50+ binaries. When all tests are cache-hits, the downstream (parallelize) exits early, and test_cmds_native's echo calls receive SIGPIPE (exit 141). Fix by using set +o pipefail + PIPESTATUS to distinguish SIGPIPE from test_cmds (exit 141, expected when all cached) from genuine failures. Revert the earlier sentinel approach which didn't address the root cause. The root-level CI avoids this by writing tests to a file (test_engine), so test_cmds never pipes to a reader that can exit early. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
test_cmds_native runs each binary with --gtest_list_tests to enumerate tests. When all tests are cached, the downstream exits early and test_cmds_native receives SIGPIPE (exit 141). Write test commands to a temp file first (analogous to how the root-level build_and_test uses test_engine with a file). Writing to a file is immune to SIGPIPE regardless of when the downstream reader exits. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
alexghr
approved these changes
Feb 26, 2026
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Feb 27, 2026
BEGIN_COMMIT_OVERRIDE chore: builders audit response 0 (#20792) feat: early circuit block deallocation after trace populate (#20776) fix: Fix script for testing vks haven't changed (#20852) fix: move debug_incoming_circuit before block deallocation in Chonk::accumulate (#20876) refactor: deduplicate debug_incoming_circuit in Chonk::accumulate (#20870) fix: denoise causing mysterious error 141 (#20871) feat: make clang20 preset use zig with glibc 2.35 (#20897) chore: remove final instances of unneeded +1 in SRS construction (#20912) chore: avoid use of size_t in bbapi to be safe (#20916) chore: Claudebox remedy example (#20922) END_COMMIT_OVERRIDE
johnathan79717
pushed a commit
that referenced
this pull request
Mar 4, 2026
Painfully only manifested in CI, not even shell-new --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Painfully only manifested in CI, not even shell-new