fix: backport #21673 — prevent HA peer proposals from blocking equivocation in duplicate proposal test#21693
Merged
spalladino merged 4 commits intoApr 7, 2026
Conversation
AztecBot
force-pushed
the
claudebox/backport-21673-v4-next
branch
from
ae4789b to
f6ccf4e
Compare
AztecBot
changed the title
spalladino
approved these changes
Mar 18, 2026
…cation in duplicate proposal test Rebased onto latest backport-to-v4-next-staging to resolve merge conflicts. Changes from next: - Add advanceToEpochBeforeProposer helper (stops one epoch before target) - Add dontStartSequencer + skipPushProposedBlocksToArchiver on malicious nodes - Add dontStartSequencer on honest nodes with manual sequencer start - Filter offenses to only DUPLICATE_PROPOSAL type
AztecBot
force-pushed
the
claudebox/backport-21673-v4-next
branch
from
3fdf207 to
7217f98
Compare
Collaborator
Author
Flakey Tests🤖 says: This CI run detected 1 tests that failed, but were tolerated due to a .test_patterns.yml entry. |
auto-merge was automatically disabled
April 7, 2026 14:28
Squash merges are not allowed on this repository
AztecBot
added a commit
that referenced
this pull request
Apr 8, 2026
BEGIN_COMMIT_OVERRIDE fix: pippenger edge case (#22256) cherry-pick: fix: separate fisherman StatefulSet from rpc-node and stop archiver pollution (#22183) — WITH CONFLICTS fix: separate fisherman StatefulSet from rpc-node and stop archiver pollution (backport #22183) (#22284) fix: preserve DeployAccountMethod type in with() method chaining (#22322) docs: backport docs build/release infrastructure from #22106 and #22144 (#22223) chore(docs): remove v5 nightly and devnet versioned docs (backport #22193) (#22236) chore: improve release-docs skill and add release-network-docs skill (#22328) chore: remove dead to_be_bytes fn (#22243) fix: correct args length in `#[authorize_once]` (#22209) chore: fix inconsistent usage of contract class hash fn (#22248) chore: delete old field comparison fns in favor of lt (#22249) fix: all account overrides + gas limits (#22173) feat: allow for runtime length arrays of sorts and selects (#22250) chore: remove dead pub global vars reexport (#22244) chore: changed default wait behavior (#22325) chore: apply code consistency consolidation (#22251) fix(docs): simplify TypeScript API reference links (backport #22232) (#22369) fix: remove detailed revert codes (#22380) fix: backport #21673 — prevent HA peer proposals from blocking equivocation in duplicate proposal test (#21693) fix: subfield note selectors (#22211) END_COMMIT_OVERRIDE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backport of #21673 to v4-next.
Adds
dontStartSequencer: trueandskipPushProposedBlocksToArchiver: trueto the malicious nodes in theduplicate_proposal_slashe2e test. This prevents HA peer proposals from being added to the archiver, so both malicious nodes build their own blocks instead of one yielding to the other.Note: v4-next also needed
dontStartSequencer: true(from PR #21603) which was already onnextwhen the original PR was merged, so this backport includes both properties.Conflict Resolution
The cherry-pick conflicted because v4-next lacked the
dontStartSequencer: trueline added by PR #21603. Resolution was to accept both new properties (dontStartSequencerandskipPushProposedBlocksToArchiver).Commits
Test plan
duplicate_proposal_slashe2e test should pass with these changes