Skip to content

fix: separate fisherman StatefulSet from rpc-node and stop archiver pollution (backport #22183)#22284

Merged
ludamad merged 2 commits into
backport-to-v4-next-stagingfrom
claudebox/backport-22183-fisherman-v4-next
Apr 3, 2026
Merged

fix: separate fisherman StatefulSet from rpc-node and stop archiver pollution (backport #22183)#22284
ludamad merged 2 commits into
backport-to-v4-next-stagingfrom
claudebox/backport-22183-fisherman-v4-next

Conversation

@AztecBot

@AztecBot AztecBot commented Apr 2, 2026

Copy link
Copy Markdown
Collaborator

Summary

Backport of #22183 to v4-next.

Code fix (checkpoint_proposal_job.ts): syncProposedBlockToArchiver now skips the archiver push when fishermanMode is true, preventing spurious reorg cascades on mainnet.

Infrastructure split (main.tf, variables.tf, deploy_network.sh): Replaces FISHERMAN_MODE with FISHERMAN_REPLICAS and adds a dedicated fisherman Helm release as a separate StatefulSet.

Conflicts resolved

  • spartan/.gitignore: Removed ignition-fisherman.env entry (PR intent was to delete it; block-capacity.env doesn't exist on v4-next)
  • spartan/environments/devnet-avm-prover.env, ignition-fisherman.env: Deleted (modify/delete — PR deletes, v4-next had modifications)
  • spartan/environments/mainnet.env: Kept deleted (doesn't exist on v4-next)
  • checkpoint_proposal_job.ts: Merged v4-next's !== false condition with PR's || this.config.fishermanMode addition

ClaudeBox log: https://claudebox.work/s/b82065b06bcc585b?run=1

spypsy and others added 2 commits April 2, 2026 17:10
- .gitignore: removed ignition-fisherman.env entry (PR intent was to delete it)
- devnet-avm-prover.env, ignition-fisherman.env: deleted (already removed on next)
- mainnet.env: kept deleted (doesn't exist on v4-next)
- checkpoint_proposal_job.ts: merged both conditions (kept !== false from v4-next + added fishermanMode check from PR)
@AztecBot AztecBot added ci-draft Run CI on draft PRs. claudebox Owned by claudebox. it can push to this PR. labels Apr 2, 2026

@alexghr alexghr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@spypsy spypsy marked this pull request as ready for review April 3, 2026 11:04
@ludamad ludamad merged commit 5a233f4 into backport-to-v4-next-staging Apr 3, 2026
25 of 29 checks passed
@ludamad ludamad deleted the claudebox/backport-22183-fisherman-v4-next branch April 3, 2026 19:01
AztecBot added a commit that referenced this pull request Apr 8, 2026
BEGIN_COMMIT_OVERRIDE
fix: pippenger edge case (#22256)
cherry-pick: fix: separate fisherman StatefulSet from rpc-node and stop
archiver pollution (#22183) — WITH CONFLICTS
fix: separate fisherman StatefulSet from rpc-node and stop archiver
pollution (backport #22183) (#22284)
fix: preserve DeployAccountMethod type in with() method chaining
(#22322)
docs: backport docs build/release infrastructure from #22106 and #22144
(#22223)
chore(docs): remove v5 nightly and devnet versioned docs (backport
#22193) (#22236)
chore: improve release-docs skill and add release-network-docs skill
(#22328)
chore: remove dead to_be_bytes fn (#22243)
fix: correct args length in `#[authorize_once]` (#22209)
chore: fix inconsistent usage of contract class hash fn (#22248)
chore: delete old field comparison fns in favor of lt (#22249)
fix: all account overrides + gas limits (#22173)
feat: allow for runtime length arrays of sorts and selects (#22250)
chore: remove dead pub global vars reexport (#22244)
chore: changed default wait behavior (#22325)
chore: apply code consistency consolidation (#22251)
fix(docs): simplify TypeScript API reference links (backport #22232)
(#22369)
fix: remove detailed revert codes (#22380)
fix: backport #21673 — prevent HA peer proposals from blocking
equivocation in duplicate proposal test (#21693)
fix: subfield note selectors (#22211)
END_COMMIT_OVERRIDE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-draft Run CI on draft PRs. claudebox Owned by claudebox. it can push to this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants