fix!: dsl inf#21865
Merged
Merged
Conversation
2 tasks
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Mar 23, 2026
…1909) ## Summary - Pin `typescript@^5.3.3` in docs examples validation to match `yarn-project`. The unpinned `yarn add -D typescript` started pulling TypeScript 6.0, which changed JSON import type inference and made existing `@ts-expect-error` directives unused (TS2578 errors), breaking `example_swap` type-checking. - Use git state (`git show HEAD:...`) instead of filesystem state (`-s`) for yarn.lock emptiness check. When `example_swap` fails, GNU parallel's `--halt now,fail=1` kills other jobs mid-`yarn add` before cleanup traps run, leaving lockfiles dirty on disk. On retry, the check found dirty filesystem state and reported the misleading `token_bridge/yarn.lock is not empty` error. ## Context Multiple unrelated PRs (#21865, #21907, #21812) are failing with: ``` ERROR: token_bridge/yarn.lock is not empty. These files must be committed empty. ``` Root cause chain: 1. `yarn add -D typescript` (unpinned) pulls TS 6.0, released today 2. TS 6.0 improved JSON import type inference, making `@ts-expect-error` directives unused → TS2578 errors in `example_swap` 3. `example_swap` fails → `--halt now,fail=1` kills `token_bridge` mid-`yarn add` → cleanup trap never runs 4. Retry finds dirty `token_bridge/yarn.lock` on filesystem → misleading error ## Test plan - [ ] CI passes on this PR (docs examples validation succeeds) - [ ] Verify `example_swap` and `token_bridge` type-check cleanly with pinned TS 5.x 🤖 Generated with [Claude Code](https://claude.com/claude-code)
Collaborator
Flakey Tests🤖 says: This CI run detected 1 tests that failed, but were tolerated due to a .test_patterns.yml entry. |
ledwards2225
merged commit c0a4818
into
merge-train/barretenberg
20 of 21 checks passed
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Mar 24, 2026
BEGIN_COMMIT_OVERRIDE fix!: dsl inf (#21865) END_COMMIT_OVERRIDE
ledwards2225
added a commit
that referenced
this pull request
Apr 10, 2026
| # | Finding | Resolution | |---|---------|------------| | 3, 12 | Msgpack NIL produces null `shared_ptr`, dereferenced in ACIR parsers | **Patched.** NIL rejection in deserializer helpers, plus tests | | 6 | `result_infinite` unconstrained in EC gadgets; prover could forge it | **Already fixed** in PR #21865 | | 9 | `assert_valid_variables` debug-only, heap-allocated a vector per call | **Patched.** Updated to use `initializer_list`/`span` to make cheap enough, always-on, (check in `get_variable` too expensive) | | 16 | Sparse witness map amplifies ~10 bytes into ~137 GB allocation | **Accepted risk.** No cap works without potentially rejecting valid inputs | | 20 | UB shift-by-64 in `get_wnaf_bits`; hash tests Ultra-only | **Patched.** Fixed UB, added Mega coverage to 4 test suites | | 21 | Clang under-aligns NTTP objects, UB in `barrett_reduction` | **Patched.** Root cause different than claimed in issue (see `static_assert` guards), Pointer NTTP refactor resolves UB per UBsan |
critesjosh
pushed a commit
that referenced
this pull request
Apr 14, 2026
| # | Finding | Resolution | |---|---------|------------| | 3, 12 | Msgpack NIL produces null `shared_ptr`, dereferenced in ACIR parsers | **Patched.** NIL rejection in deserializer helpers, plus tests | | 6 | `result_infinite` unconstrained in EC gadgets; prover could forge it | **Already fixed** in PR #21865 | | 9 | `assert_valid_variables` debug-only, heap-allocated a vector per call | **Patched.** Updated to use `initializer_list`/`span` to make cheap enough, always-on, (check in `get_variable` too expensive) | | 16 | Sparse witness map amplifies ~10 bytes into ~137 GB allocation | **Accepted risk.** No cap works without potentially rejecting valid inputs | | 20 | UB shift-by-64 in `get_wnaf_bits`; hash tests Ultra-only | **Patched.** Fixed UB, added Mega coverage to 4 test suites | | 21 | Clang under-aligns NTTP objects, UB in `barrett_reduction` | **Patched.** Root cause different than claimed in issue (see `static_assert` guards), Pointer NTTP refactor resolves UB per UBsan |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explicitly connect the infinity flags for grumpkin points generated in acir to their counterparts in cycle group in the DSL module. Credit: @suyash67