chore: misc hash gadget updates #22452
Merged
Merged
Conversation
ludamad
reviewed
Apr 10, 2026
suyash67
reviewed
Apr 10, 2026
| const uint64_t hi = spans_limbs ? (scalar[hi_limb_idx] << (64UL - lo_shift)) : 0UL; | ||
|
|
||
| return (lo & bit_mask) | (hi & hi_mask); | ||
| return (lo | hi) & bit_mask; |
ludamad
approved these changes
Apr 10, 2026
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Apr 13, 2026
BEGIN_COMMIT_OVERRIDE fix: skip heavy recursion tests in debug builds (#22446) fix: add clear error for unsatisfiable ACIR AssertZero opcode (#22417) feat: enforce accumulator_not_empty = 0 at ECCVM lagrange_first row (#22461) fix: skip heavy recursion tests in debug builds, keep one for assertion coverage (#22389) fix: external audit fixes for Pedersen (#22434) chore!: fix BASE off-by-one in create_small_range_constraint in theta step of keccak (#22404) fix: external audit fixes for Keccak (#22436) fix: external audit fixes for BLAKE (#22443) chore: misc hash gadget updates (#22452) END_COMMIT_OVERRIDE
critesjosh
pushed a commit
that referenced
this pull request
Apr 14, 2026
| # | Finding | Resolution | |---|---------|------------| | 3, 12 | Msgpack NIL produces null `shared_ptr`, dereferenced in ACIR parsers | **Patched.** NIL rejection in deserializer helpers, plus tests | | 6 | `result_infinite` unconstrained in EC gadgets; prover could forge it | **Already fixed** in PR #21865 | | 9 | `assert_valid_variables` debug-only, heap-allocated a vector per call | **Patched.** Updated to use `initializer_list`/`span` to make cheap enough, always-on, (check in `get_variable` too expensive) | | 16 | Sparse witness map amplifies ~10 bytes into ~137 GB allocation | **Accepted risk.** No cap works without potentially rejecting valid inputs | | 20 | UB shift-by-64 in `get_wnaf_bits`; hash tests Ultra-only | **Patched.** Fixed UB, added Mega coverage to 4 test suites | | 21 | Clang under-aligns NTTP objects, UB in `barrett_reduction` | **Patched.** Root cause different than claimed in issue (see `static_assert` guards), Pointer NTTP refactor resolves UB per UBsan |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
shared_ptr, dereferenced in ACIR parsersresult_infiniteunconstrained in EC gadgets; prover could forge itassert_valid_variablesdebug-only, heap-allocated a vector per callinitializer_list/spanto make cheap enough, always-on, (check inget_variabletoo expensive)get_wnaf_bits; hash tests Ultra-onlybarrett_reductionstatic_assertguards), Pointer NTTP refactor resolves UB per UBsan