feat(aztec-nr)!: domain-separated tags on log emission#21910
Merged
Conversation
nchamo
changed the title
nchamo
commented
Mar 23, 2026
nchamo
commented
Mar 23, 2026
nchamo
added
the
ci-no-fail-fast
nchamo
force-pushed
the
feat/domain-separated-log-tags
branch
from
c5cbeee to
7e1b1f5
Compare
nchamo
commented
Mar 23, 2026
nchamo
commented
Mar 23, 2026
nchamo
commented
Mar 23, 2026
nchamo
commented
Mar 23, 2026
nchamo
commented
Mar 23, 2026
nchamo
requested review from
dbanks12,
fcarreiro and
sirasistant
as code owners
nchamo
commented
Mar 24, 2026
nchamo
commented
Mar 24, 2026
…omain-separated-log-tags # Conflicts: # docs/docs-developers/docs/resources/migration_notes.md
nventuro
reviewed
Mar 25, 2026
nventuro
approved these changes
Mar 25, 2026
…omain-separated-log-tags # Conflicts: # docs/docs-developers/docs/resources/migration_notes.md # noir-projects/aztec-nr/aztec/src/messages/logs/partial_note.nr # noir-projects/aztec-nr/uint-note/src/uint_note.nr # noir-projects/noir-contracts/contracts/app/nft_contract/src/types/nft_note.nr # noir-projects/noir-protocol-circuits/crates/types/src/constants_tests.nr
Collaborator
|
❌ Failed to cherry-pick to |
nchamo
added a commit
that referenced
this pull request
Mar 26, 2026
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Mar 26, 2026
BEGIN_COMMIT_OVERRIDE feat(aztec-nr): add initialization check to utility functions (#21751) refactor(aztec-nr): remove storage from init_test_contract (#21996) chore: remove claude file (#22012) refactor!: more consistent oracle names (#22018) feat(aztec-nr)!: app-silo getSharedSecret oracle (#22020) fix: disallow infinite pubkeys (#22026) feat: aztecnr log prefixing (#22027) feat(aztec-nr)!: domain-separated tags on log emission (#21910) END_COMMIT_OVERRIDE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
All logs emitted through the framework now include a domain-separated tag at
fields[0]. Each log category uses its own domain separator viacompute_log_tag(raw_tag, dom_sep):DOM_SEP__EVENT_LOG_TAG): the event type ID is the raw tagDOM_SEP__UNCONSTRAINED_MSG_LOG_TAG): the discovery tag is the raw tag, separator chosen based on delivery modeDOM_SEP__NOTE_COMPLETION_LOG_TAG): the partial note commitment is the raw tagThe low-level emit methods now take
tagas an explicit first parameter and have been renamed with an_unsafesuffix to signal that calling them directly bypasses the framework's tagging:emit_private_log_unsafe(tag, log, length)emit_raw_note_log_unsafe(tag, log, length, note_hash_counter)emit_public_log_unsafe(tag, log)On the TypeScript side,
computeLogTagandSiloedTag.computeapply the appropriate domain separator, andgetPublicEventsfilters by domain-separated event tag server-side.Fixes F-424
Fixes F-224.