feat(aztec-nr)!: domain-separated tags on log emission (#21910) [v4-next backport]#22031
Merged
nchamo merged 2 commits intoMar 26, 2026
Merged
Conversation
Resolved conflicts in 3 files: - benchmarking_contract: took incoming imports and new benchmark functions - test_contract: took incoming constants (PRIVATE_LOG_CIPHERTEXT_LEN, MAX_PUBLIC_LOG_SIZE_IN_FIELDS) and new emit_full_size_public_log function - constants.gen.ts: kept both SILOED_NULLIFIER (HEAD) and new log tag domain separators (incoming)
AztecBot
added
ci-draft
nchamo
requested review from
LeilaWang,
dbanks12,
fcarreiro,
nventuro and
sirasistant
as code owners
nchamo
approved these changes
Mar 26, 2026
Collaborator
Author
Flakey Tests🤖 says: This CI run detected 1 tests that failed, but were tolerated due to a .test_patterns.yml entry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backport of #21910 to v4-next.
Cherry-pick of 8c88e11 had 3 conflicts:
benchmarking_contract/main.nr — HEAD had minimal imports, incoming added new benchmark functions (
noop,emit_nullifiers,emit_note_hashes,emit_l2_to_l1_msgs,emit_private_logs,emit_contract_class_log,noop_pub) and their required imports. Took incoming.test_contract/main.nr — HEAD imported
PRIVATE_LOG_SIZE_IN_FIELDS, incoming importedPRIVATE_LOG_CIPHERTEXT_LENandMAX_PUBLIC_LOG_SIZE_IN_FIELDSplus newemit_full_size_public_logfunction. Took incoming (the old constant was renamed in this PR).constants.gen.ts — HEAD had
SILOED_NULLIFIERin DomainSeparator enum, incoming had new log tag constants. Kept both sinceSILOED_NULLIFIERexists on v4-next but was already present upstream when the PR was authored.All constants verified against
constants.nrsource — values match.ClaudeBox log: https://claudebox.work/s/7911e670cba71a16?run=1