Skip to content

fix: verify accumulated pairing points in native ChonkVerifier (v4 backport)#21975

Merged
ludamad merged 1 commit into
v4from
fix/chonk-pairing-check-v4
Mar 24, 2026
Merged

fix: verify accumulated pairing points in native ChonkVerifier (v4 backport)#21975
ludamad merged 1 commit into
v4from
fix/chonk-pairing-check-v4

Conversation

@ludamad

@ludamad ludamad commented Mar 24, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Backport of 50ba735 to v4
  • Native ChonkVerifier::verify was missing kernel_io.pairing_inputs.check() — the accumulated pairing points from inner recursive verifications
  • The recursive verifier already included this check; the native verifier did not
  • Adds the missing check for parity between native and recursive verification paths

Backport of 50ba735 to v4. The native ChonkVerifier::verify was not
checking kernel_io.pairing_inputs (accumulated pairing points from the
IVC chain), while the recursive verifier was. This adds the missing
check to ensure parity between native and recursive verification paths.
@ludamad ludamad added the ci-barretenberg Run all barretenberg/cpp checks. label Mar 24, 2026
@ludamad ludamad enabled auto-merge (squash) March 24, 2026 20:54
@ludamad ludamad disabled auto-merge March 24, 2026 20:56
@ludamad ludamad changed the base branch from backport-to-v4-staging to v4 March 24, 2026 20:56
@ludamad ludamad requested a review from a team March 24, 2026 20:56
@ludamad ludamad enabled auto-merge March 24, 2026 20:57
@ludamad ludamad added ci-skip and removed ci-barretenberg Run all barretenberg/cpp checks. labels Mar 24, 2026
@ludamad ludamad disabled auto-merge March 24, 2026 20:57
@ludamad ludamad enabled auto-merge March 24, 2026 20:58
@ludamad ludamad merged commit bef541f into v4 Mar 24, 2026
22 of 28 checks passed
@ludamad ludamad deleted the fix/chonk-pairing-check-v4 branch March 24, 2026 20:59
spalladino added a commit that referenced this pull request Mar 26, 2026
## Summary
Merges v4 branch into backport-to-v4-next-staging to bring in 17 commits
from v4 that were missing.

Key changes from v4:
- fix: verify accumulated pairing points in native ChonkVerifier
(#21975)
- chore: Properly compute finalized block (#21795, #21850)
- feat(archiver): validate contract instance addresses before storing
(#21787)
- feat(p2p): add tx validator for contract instance deployment addresses
(#21771)
- Various accumulated backports and bug fixes

## Conflicts resolved
6 files had merge conflicts, all resolved:
- `archiver/src/factory.ts` — kept `ContractClassPublicWithCommitment`
type from staging
- `archiver/src/modules/data_store_updater.ts` — merged imports from
both branches
- `archiver/src/store/kv_archiver_store.test.ts` — took v4's richer
describe block structure, adapted to singular `addProposedBlock` API
- `aztec-node/src/aztec-node/server.ts` — kept staging's block 0 check
and `getWorldState` method name
- `stdlib/src/tx/validator/error_texts.ts` — kept staging's contract
class error constants
- `world-state/src/synchronizer/server_world_state_synchronizer.ts` —
kept verbose log level

## Test plan
- CI should verify the merge compiles and tests pass
- Once merged, this branch can be merged into the backport-to-v4-next
branch

ClaudeBox log: https://claudebox.work/s/0150633f06bfb379?run=1
AztecBot added a commit that referenced this pull request Apr 1, 2026
Forward-port of the v4 fix (PR #21975). The native ChonkVerifier::reduce_to_ipa_claim
was missing the kernel_io.pairing_inputs.check() call, which verifies the accumulated
pairing points from inner recursive verifications. The recursive verifier already
aggregates these points; the native verifier must explicitly check them.
iakovenkos pushed a commit that referenced this pull request Apr 1, 2026
## Summary
Forward-port of the v4 fix
(#21975).

The native `ChonkVerifier::reduce_to_ipa_claim` was missing
`kernel_io.pairing_inputs.check()` — the accumulated pairing points from
inner recursive verifications. The recursive verifier already aggregates
these points; the native verifier must explicitly check them.

## Details
- Added `kernel_io.pairing_inputs.check()` after
`reconstruct_from_public` in the native `reduce_to_ipa_claim`
- This completes parity between native and recursive verification paths
- `chonk_tests` builds successfully

ClaudeBox log: https://claudebox.work/s/fe964a7f5fb2b43c?run=1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants