Skip to content

fix: verify accumulated pairing points in native ChonkVerifier#22224

Merged
iakovenkos merged 1 commit into
merge-train/barretenbergfrom
claudebox/fwd-port-chonk-pairing-points
Apr 1, 2026
Merged

fix: verify accumulated pairing points in native ChonkVerifier#22224
iakovenkos merged 1 commit into
merge-train/barretenbergfrom
claudebox/fwd-port-chonk-pairing-points

Conversation

@AztecBot

@AztecBot AztecBot commented Apr 1, 2026

Copy link
Copy Markdown
Collaborator

Summary

Forward-port of the v4 fix (#21975).

The native ChonkVerifier::reduce_to_ipa_claim was missing kernel_io.pairing_inputs.check() — the accumulated pairing points from inner recursive verifications. The recursive verifier already aggregates these points; the native verifier must explicitly check them.

Details

  • Added kernel_io.pairing_inputs.check() after reconstruct_from_public in the native reduce_to_ipa_claim
  • This completes parity between native and recursive verification paths
  • chonk_tests builds successfully

ClaudeBox log: https://claudebox.work/s/fe964a7f5fb2b43c?run=1

Forward-port of the v4 fix (PR #21975). The native ChonkVerifier::reduce_to_ipa_claim
was missing the kernel_io.pairing_inputs.check() call, which verifies the accumulated
pairing points from inner recursive verifications. The recursive verifier already
aggregates these points; the native verifier must explicitly check them.
@AztecBot AztecBot added ci-draft Run CI on draft PRs. claudebox Owned by claudebox. it can push to this PR. labels Apr 1, 2026
@iakovenkos iakovenkos marked this pull request as ready for review April 1, 2026 13:51
@iakovenkos iakovenkos self-requested a review April 1, 2026 13:52
@iakovenkos iakovenkos enabled auto-merge (squash) April 1, 2026 13:52
@iakovenkos iakovenkos merged commit 18c3fc6 into merge-train/barretenberg Apr 1, 2026
47 of 55 checks passed
@iakovenkos iakovenkos deleted the claudebox/fwd-port-chonk-pairing-points branch April 1, 2026 14:15
github-merge-queue Bot pushed a commit that referenced this pull request Apr 2, 2026
BEGIN_COMMIT_OVERRIDE
fix: verify accumulated pairing points in native ChonkVerifier (#22224)
chore: enable _GLIBCXX_DEBUG in debug build presets (#22218)
feat: add --memory_profile_out flag for Chonk memory profiling (#22145)
fix: disable max capacity test in debug + tiny gate separator
improvements (#22215)
fix: WASM build for memory_profile.cpp (#22231)
fix: translator audit fixes (#22242)
fix: remove constexpr from functions using std::vector for
_GLIBCXX_DEBUG compat (#22239)
fix: pippenger edge case (#22256)
fix: avoid dereferencing past-the-end vector iterators in serialize.hpp
(#22261)
chore: crypto primitives external audit response 0 (#22263)
feat: switch memory profiling from peak RSS to live heap usage (#22266)
fix: replace UB end-iterator dereference in serialize.hpp (#22262)
fix: catch exceptions in ChonkBatchVerifier::batch_check (#22270)
END_COMMIT_OVERRIDE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-draft Run CI on draft PRs. claudebox Owned by claudebox. it can push to this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants