chore: Remove Noir builtin comptime mutable methods from macros (#21801) [v4-next backport]#22032
Closed
AztecBot wants to merge 8 commits into
Closed
Conversation
…ods from macros (with conflicts)
The add_abi and disable comptime methods are not available in the v4-next
Noir compiler. Reverted events.nr to use add_attribute("abi(events)") and
internals_functions_generation/mod.nr to use the old set_body/set_parameters/
add_attribute/set_return_public pattern.
The only_self noinitcheck logic change (functions/mod.nr + utils.nr) is kept
as it only uses existing APIs (has_named_attribute, is_fn_only_self).
AztecBot
added
ci-draft
… v4-next" This reverts commit 1daa487.
Updates noir-repo to match the version on next branch, which includes the add_abi and disable comptime APIs needed by the original PR changes.
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Contributor
|
Chamo took over this PR in #22020 |
Contributor
|
Closed this by mistake. I thought I am in a different PR. |
…801-remove-noir-comptime
Backports changes from PR #20702 which are required for the Noir compiler change that disallows comptime globals in runtime contexts: - Update poseidon dependency from v0.2.3 to v0.2.6 - Update bignum from v0.9.0 to v0.9.2 and bigcurve from v0.13.0 to v0.13.2 - Remove comptime keyword from VK tree constant declarations - Fix comptime global RATE in poseidon2.nr
Contributor
|
As mentioned here backporting this is currently not planned so I am closing this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backport of #21801 to v4-next.
All original changes are now applied as-is, including
add_abiandfunction.disable()calls, since the noir submodule has been updated to thenextversion (f7a7e6c161) which includes these APIs.Changes
events.nr:s.add_attribute("abi(events)")→s.add_abi("events")functions/mod.nr: removedf.add_attribute("noinitcheck")fromonly_selfinternals_functions_generation/mod.nr: replaced manual body/params manipulation withfunction.disable(error_message)utils.nr:fn_has_noinitchecknow also checksis_fn_only_self(f)noir/noir-repo: updated submodule tonextversion.test_patterns.yml: added flaky test entryCommits
.test_patterns.yml)